Skip to content

Added support for python-lightning 2.5#48

Draft
ExtReMLapin wants to merge 3 commits intotlpss:mainfrom
ExtReMLapin:lightning25
Draft

Added support for python-lightning 2.5#48
ExtReMLapin wants to merge 3 commits intotlpss:mainfrom
ExtReMLapin:lightning25

Conversation

@ExtReMLapin
Copy link
Copy Markdown

No description provided.

@ExtReMLapin
Copy link
Copy Markdown
Author

Also moving to lightning 2.5 introduces a bug where we need to start ddp with torchrun

ref #46 (comment)

@tlpss
Copy link
Copy Markdown
Owner

tlpss commented May 16, 2025

regarding the switch to 2.X
For me the discontinued support for argparse was a dealbreaker. I think your current approach does not expose all arguments of the Trainer class? Can you think of ways to handle them all?

I had in mind to switch to Draccus or Hydra for configurations because the current argparser has other limitations as well (including maintainability), but that requires some more work, and I haven't prioritized it so far.

@ExtReMLapin
Copy link
Copy Markdown
Author

ExtReMLapin commented May 16, 2025

My policy is to always stick to the latest possible version of the packages.

Simple example :

Latest GPUs from nvidia requires compute capability 120, which is only available in latest version of triton which requires the latest version of torch.

So if any of the packages you have is not ready to be used with the lastest version because you decided to stick to a 3yo version, you're fucked


Right before leaving the office 1h ago i also fixed albumentation +2.0 compatibility, took 5 secs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants