Spark support: Add @turnkey/spark private package#1302
Conversation
f0b497c to
21caba2
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ccfef89:
|
Co-authored-by: Copilot <[email protected]>
21caba2 to
543e428
Compare
2c3fb14 to
2e3d274
Compare
4232c16 to
f4fc10f
Compare
moeodeh3
left a comment
There was a problem hiding this comment.
nit: can we remove generated-docs/sdks.json?
I believe this file is only used to generate our Mintlify docs. This definitely show that what we’re doing here is a bit confusing, but basically:
pnpm generate-docs is intended to be run only by our docs repo because it also performs other things too (like deleting this file afterward, since it’s supposed to be ephemeral!)
see here
moeodeh3
left a comment
There was a problem hiding this comment.
can we also add this new package to ci.json so it gets built in our CI sandbox job?
f4fc10f to
9e2a67b
Compare
Should we then |
9e2a67b to
0b9d2cb
Compare
done |
0b9d2cb to
ccfef89
Compare

Summary & Motivation
Step 1 for implementing a Turnkey-backed Spark signer - creating a new
@turnkey/sparkpackage and moving the existing signer implmentation from the spark example.The package will not be published yet (
privateis set totrue)Notes
pnpmoverride for@confio/[email protected]>protobufjshas been removed - this package is no longer with uspnpmoverride forprotobufjshas been added due to a new vulnerability brought in by the@buildonspark/spark-sdkpackageexamples/spark-with-schnorrhas been renamed toexamples/with-sparkHow I Tested These Changes
Nohow yet
Did you add a changeset?
No packages updated