Skip to content

Spark support: Add @turnkey/spark private package#1302

Merged
janjakubnanista merged 3 commits into
mainfrom
jan/spark-sdk
May 14, 2026
Merged

Spark support: Add @turnkey/spark private package#1302
janjakubnanista merged 3 commits into
mainfrom
jan/spark-sdk

Conversation

@janjakubnanista
Copy link
Copy Markdown
Contributor

@janjakubnanista janjakubnanista commented May 13, 2026

Summary & Motivation

Step 1 for implementing a Turnkey-backed Spark signer - creating a new @turnkey/spark package and moving the existing signer implmentation from the spark example.

The package will not be published yet (private is set to true)

Notes

  • pnpm override for @confio/[email protected]>protobufjs has been removed - this package is no longer with us
  • pnpm override for protobufjs has been added due to a new vulnerability brought in by the @buildonspark/spark-sdk package
  • examples/spark-with-schnorr has been renamed to examples/with-spark

How I Tested These Changes

Nohow yet

Did you add a changeset?

No packages updated

@janjakubnanista janjakubnanista self-assigned this May 13, 2026
@janjakubnanista janjakubnanista marked this pull request as ready for review May 13, 2026 18:04
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented May 13, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ccfef89:

Sandbox Source
@turnkey/example-react-components Configuration

andrewkmin
andrewkmin previously approved these changes May 13, 2026
Comment thread packages/spark/documents/docs.md Outdated
Comment thread examples/with-spark/src/index.ts
andrewkmin
andrewkmin previously approved these changes May 13, 2026
Comment thread packages/spark/documents/docs.md Outdated
Copy link
Copy Markdown
Contributor

@moeodeh3 moeodeh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we remove generated-docs/sdks.json?

I believe this file is only used to generate our Mintlify docs. This definitely show that what we’re doing here is a bit confusing, but basically:

pnpm generate-docs is intended to be run only by our docs repo because it also performs other things too (like deleting this file afterward, since it’s supposed to be ephemeral!)

see here

Copy link
Copy Markdown
Contributor

@moeodeh3 moeodeh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add this new package to ci.json so it gets built in our CI sandbox job?

Comment thread packages/sdk-server/src/__inputs__/public_api.types.ts Outdated
@janjakubnanista
Copy link
Copy Markdown
Contributor Author

nit: can we remove generated-docs/sdks.json?

I believe this file is only used to generate our Mintlify docs. This definitely show that what we’re doing here is a bit confusing, but basically:

pnpm generate-docs is intended to be run only by our docs repo because it also performs other things too (like deleting this file afterward, since it’s supposed to be ephemeral!)

see here

Should we then .gitignore it?

@janjakubnanista
Copy link
Copy Markdown
Contributor Author

can we also add this new package to ci.json so it gets built in our CI sandbox job?

done

@janjakubnanista
Copy link
Copy Markdown
Contributor Author

can we also add this new package to ci.json so it gets built in our CI sandbox job?

done

undone

Screenshot 2026-05-13 at 3 11 56 PM

@janjakubnanista janjakubnanista merged commit 59344b7 into main May 14, 2026
11 of 12 checks passed
@janjakubnanista janjakubnanista deleted the jan/spark-sdk branch May 14, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants