prettify ✨ #50
Merged
prettify ✨ #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good besides the merge conflicts to resolve :) |
andrewkmin
force-pushed
the
andrew/prettify
branch
from
ea0a094 to
d599533
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Contributor
Author
resolved! |
r-n-o
reviewed
Aug 8, 2024
Collaborator
r-n-o
left a comment
r-n-o
left a comment
There was a problem hiding this comment.
We might want to exclude noble-ed25519.js and noble-hashes.js from the list of linted files: they're vendored in.
r-n-o
approved these changes
Aug 8, 2024
Collaborator
r-n-o
left a comment
r-n-o
left a comment
There was a problem hiding this comment.
Other than that though: looks good, only whitespace changes, so no reason to block 👍
andrewkmin
force-pushed
the
andrew/prettify
branch
from
5d124f9 to
54a2247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$title