This repository was archived by the owner on May 22, 2022. It is now read-only.
Fix bug where Windows line endings affect the dependency hash#39
Open
nerdydrew wants to merge 1 commit intotkawachi:masterfrom
Open
Fix bug where Windows line endings affect the dependency hash#39nerdydrew wants to merge 1 commit intotkawachi:masterfrom
nerdydrew wants to merge 1 commit intotkawachi:masterfrom
Conversation
Even though lock files are written out with Unix line endings, some systems may convert them to Windows line endings (e.g. Git's autocrlf setting). Trimming ensures that the dependency hash remains the same, regardless of operating system or line endings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the dependency hash changes if the lock file gets converted to Windows line endings (CRLF) for whatever reason, such as if Git's
autocrlfsetting is enabled on Windows. If this happens,readDepsHashwould return the hash with a\ron the end, making it different from before. Trimming whitespace fixes the issue.