Skip to content

Conversation

@mw-root
Copy link

@mw-root mw-root commented Sep 13, 2023

Description

This PR adds code to pull the description field for actions and add it to the docs if defined.

I am not a great go dev, so I have tried to keep these changes in line with the existing code base.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ccc464) 91.53% compared to head (84142c7) 91.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files           1        1           
  Lines         130      130           
=======================================
  Hits          119      119           
  Misses          8        8           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackton1 jackton1 force-pushed the adding-action-description branch from 5077122 to 596be03 Compare September 14, 2023 17:30
@jackton1
Copy link
Contributor

Hi, @mw-root If you're curious you can add a new test to this file cmd/root_test.go.

@jackton1
Copy link
Contributor

@all-contributors please add @mw-root for code and docs

@allcontributors
Copy link
Contributor

@jackton1

I've put up a pull request to add @mw-root! 🎉

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@mw-root mw-root force-pushed the adding-action-description branch from 81bb565 to 6e87e07 Compare September 15, 2023 17:57
@mw-root mw-root force-pushed the adding-action-description branch from 6e87e07 to 1169b3a Compare September 18, 2023 14:44
@mw-root
Copy link
Author

mw-root commented Sep 18, 2023

Hi, @mw-root If you're curious you can add a new test to this file cmd/root_test.go.

Hi @jackton1 , I added description markers to a couple MD files in test.
These tests all seem to hinge on whether or not the tool ran successfully, so I figured adding desc tags would cover that. Did you want another run with something specific for the action description?

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdownlint (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@jackton1 jackton1 self-requested a review September 19, 2023 16:42
@jackton1 jackton1 added the merge when passing Merge the PR automatically once all status checks have passed label Sep 19, 2023
@repo-ranger repo-ranger bot merged commit 492e7bf into tj-actions:main Sep 19, 2023
@jackton1
Copy link
Contributor

Hi, @mw-root If you're curious you can add a new test to this file cmd/root_test.go.

Hi @jackton1 , I added description markers to a couple MD files in test. These tests all seem to hinge on whether or not the tool ran successfully, so I figured adding desc tags would cover that. Did you want another run with something specific for the action description?

That was all good. I made some minor edits after testing it everything worked as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge merge when passing Merge the PR automatically once all status checks have passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants