[Mellanox] Fix get component versions script to fetch correct asic fw#16
Open
tirupatihemanth wants to merge 2 commits intomasterfrom
Open
[Mellanox] Fix get component versions script to fetch correct asic fw#16tirupatihemanth wants to merge 2 commits intomasterfrom
tirupatihemanth wants to merge 2 commits intomasterfrom
Conversation
dgsudharsan
approved these changes
Mar 17, 2026
Collaborator
|
Can you verify this both on switch and DPU side? |
Signed-off-by: Hemanth Kumar Tirupati <tirupatihemanthkumar@gmail.com>
tirupatihemanth
force-pushed
the
fix_get_components_fw
branch
from
e25132f to
61e8471
Compare
Signed-off-by: Hemanth Kumar Tirupati <tirupatihemanthkumar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
In systems with DPUs alongside a main Spectrum switch ASIC, running mlxfwmanager --query without specifying a device returns FW versions for all Mellanox devices. So we were inadvertently scraping the DPU firmware version instead of the main ASIC switch firmware because we always picked the first one in the output which could change. This PR ensures we always display the correct asic fw version.
How I did it
pdated get_component_versions.j2 and test_sanity_checker.py to pass the correct Spectrum ASIC device ID using asic_detect.sh -p to mlxfwmanager -d.
How to verify it
Run /usr/bin/get_component_versions.py on a smartswitch and verify that the ACTUAL FW version accurately reflects the main Spectrum ASIC version instead of the DPU's FW version from one of the DPUs.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)