feat: add runSync method to Bench to force benchmarks to be synchronous
#210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jerome-benoit
left a comment
jerome-benoit
left a comment
There was a problem hiding this comment.
Looks good at a first glance.
commit: |
jerome-benoit
changed the title
runSync method to Bench to force benchmarks to be synchronousrunSync method to Bench to force benchmarks to be synchronous
rubennorte
force-pushed
the
sync-mode
branch
from
59f21ee to
91cccfb
Compare
src/bench.ts
Outdated
| runSync (): Task[] { | ||
| if (this.concurrency != null) { | ||
| throw new Error('Cannot use `concurrency` option when using `runSync`') | ||
| } |
Collaborator
There was a problem hiding this comment.
Please do the same for the runSync method in the Task class and we're good to go (yes, it's bad to have Task exported not only as a type but unfortunately the API have already been widely abused)
rubennorte
force-pushed
the
sync-mode
branch
from
91cccfb to
34b1feb
Compare
Contributor
Author
|
Thanks for the reviews, @jerome-benoit !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also validates that all the hooks (beforeAll, beforeEach, etc.) are synchronous as well and makes the benchmark fail if any of them is async (returns a promise-like object).
I did a slight refactor to extract logic common to both sync and async, and duplicated the tests that made sense to test for flavors.
closes #202