-
Notifications
You must be signed in to change notification settings - Fork 681
Refactor TinaCloud release automation #6385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This adds a new workflow that automatically adds a "requires-tinacloud-release" label to Version Packages PRs when @tinacms/graphql has a minor or major bump. This helps identify before merge that a TinaCloud release will be needed. https://claude.ai/code/session_01DTjHgRcXFjSP7dztVKGZUF
…h.yml Instead of re-computing whether @tinacms/graphql has a minor/major bump, the publish workflow now checks if the merged "Version Packages" PR has the "requires-tinacloud-release" label (added by the new label workflow). This simplifies the logic and ensures consistency between the label (visible before merge) and the tinacloud trigger (after publish). https://claude.ai/code/session_01DTjHgRcXFjSP7dztVKGZUF
Replace pulls.list with listPullRequestsAssociatedWithCommit for finding the Version Packages PR. This is more reliable as it directly queries by merge commit SHA instead of hoping the PR is in the 10 most recently updated closed PRs. https://claude.ai/code/session_01DTjHgRcXFjSP7dztVKGZUF
|
Playwright E2E Test ResultsDetails
Skipped testschromium › retain-input-value-from-localstorage.spec.ts › Local storage retain edit test |
- Remove label-based triggering (delete add-tinacloud-release-label.yml) - Send all published packages to tinacloud on every release - Let tinacloud filter for packages it cares about
18-th
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Refactors the TinaCloud release automation to be more extensible. Instead of tinacms computing version bumps and triggering tinacloud for specific packages, tinacms now sends all published packages and tinacloud handles the filtering.
Changes
tinacms
tinacms-releasedispatch eventadd-tinacloud-release-label.ymlworkflowtinacloud
packageMappingsconfigpackage.jsonpackageMappings:Flow
Test Plan