add timezone to title in span element#175
Conversation
1ab95aa to
ff6811d
Compare
That's a feature, not a bug :) git dates are stored as unix timestamps, which is the number of seconds since the Unix Epoch on January 1st, 1970 at UTC. So the system date is irrelevant. |
|
Thanks, nice addition! |
|
Thanks for the quick response! What I meant is that it would be nice to be able to convert the datetime from the log (which is in UTC) to the local timezone automatically instead of having to explicitly set the timezone config. Maybe not by default though. That way it could automatically match the system timezone. |
|
Yes that would be nice. Probably #156 would help, but it won't display the UTC time in the local time. There are probably lots of js libraries that can convert UTC to browser timestamps, but I'm not sure this plugin should support it. |
|
@timvink I realized that I forgot to update the documentation about the new date format option as well as the fact that if it is used that the timezone should most likely be set. Shall I open another PR to update it?
Indeed. That would be best. The documentation talks about doing a conversion between client and server timezone for |
Follow-up to #152 where we discussed to add the timezone.
There is a weird behaviour with the timezone. It does not seem to respect the timezone the process is run in.
For example:
Still shows
UTC.Maybe it is intended due to the
timezoneconfig setting. However, I wonder if it would not be better to callastimezone()instead to get the current timezone.