Release 1.6.0 discussion

[rockymeza]

Note: this pull request is not ready to be merged in.

I am opening up the version 1.6.0 release for discussion. In this pull request, I think we should talk about the features that need to be added or removed before we can cut a new version of moment. Here are some changes that I think should be in version 1.6.

Languages

• A grammatical change  #260, grammatical change for Swedish
• Added Japanese ext and Changed some format in Chinese #229, Japanese
• Icelandic translation #246, Icelandic
• Fixed the meridiem value for Chinese. #222, fixed ordering of longDateFormat for traditional and simplified Chinese #221, Chinese fixes
• The Finnish translation #226, Finnish

To be removed

• Deprecate moment.meridiem.am/AM/pm/PM #228, old-style am/AM/pm/PM handling
• Deprecate format tokens 'z zz' #227, z zz timezone tokens
• Deprecate moment.fn.native #216, moment.fn.native

New Features that have already been written

• play nicely within an Ender build #253, Ender compatibility
• Fixed the meridiem value for Chinese. #222, new-style am/AM/pm/PM handling
• Add a getter for moment.lang() #266, Adding a getter for moment.lang()
• Consider switching to iterative parser #263, new parser
• Add support for S SS SSS parsing tokens (milliseconds) #254, support for S SS and SSS millisecond tokens
• Use a duration object #236/Feature/durations #265, Durations
• Fix for issue 261. #267 - moment.clone() does not copy the _isUTC property
• Diff does not take into account utc mode. #261 - moment.diff() does not take into account utc mode
• Add support for creation with unix timestamp in seconds #213 - moment.unix() and moment.fn.unix()
• moment.utc(string) parses ISO8601 as local time when timezone is missing #275 - moment.utc(string) parses ISO8601 as local time when timezone is missing

New features that have not been written

Things that should not go into this release

• Add a getter for moment.lang() #266, per-instance language configuration -- 1.7 ???
• Moment.js overflows in parsing #235, moment.fn.isValid -- 1.7 ???
• Support for two-letter days-of-week #262, Two letter month name formatting tokens -- 1.7 ???
• Added generic functions endOf and startOf #283, Generic endOf and startOf to abstract sod/eod -- 1.7 ???

[timrwood]

We should also add moment.lang() as a getter as well. See #266.

This would be a good workaround before adding per instance lang configurations.

[timrwood]

FYI, I updated the list.

The new parser ended up taking much less time than I thought it would. It passes all the previous tests, plus the new 'YYYMMDD' tests. I think it's pretty stable, so it should be good to release.

I added lang as a getter, and moved the S/SS/SSS parsing issue up to the 'have been written' section.

I also added moment.fn.isValid and two letter month names to the 'not this release' section.

[timrwood]

I added these to the 'already written' section, and moved durations there as well.

• Fix for issue 261. #267 - moment.clone() does not copy the _isUTC property
• Diff does not take into account utc mode. #261 - moment.diff() does not take into account utc mode
• Add support for creation with unix timestamp in seconds #213 - moment.unix() and moment.fn.unix()

[timrwood]

I think this is ready to go, @rockymeza, is there anything I'm forgetting?

[rockymeza]

Looks like a good solid release to me. What about that Korean bug? We
could probably stick that in too.
-rocky

On Tue, Apr 24, 2012 at 6:19 PM, Tim Wood <
reply@reply.github.com

wrote:

I think this is ready to go, @rockymeza, is there anything I'm forgetting?

---

Reply to this email directly or view it on GitHub:
#268 (comment)

[rockymeza]

Nevermind, #284 seems to be a problem with incompatible versions of moment and and the kr.js file.

I think we're good to go @timrwood.

[timrwood]

Cool, all that is left is adding docs for durations and ender compatibility. I've created placeholders, so hopefully I can get it all written tonight. I'll ping you so you can double check them before I make the release.

[timrwood]

@rockymeza, I added docs for durations, please check it out over on https://github.com/timrwood/momentjs.com. Everything is just in the master branch there for now. (After 1.6.0 release, I think I'll switch that to git flow as well).

I also made you a collaborator on that site, so you should be able to push changes there as well.

After you look over the docs, I'll release 1.6.0.

[timrwood]

This is released!