Closed
Conversation
…jects and you take the diff, the input moment's _isUTC is ignored when you parse the input into inputMoment. I've done a check to see if it looks like a moment object (by checking the _isUTC to see if it is defined) and if it is, then it just copies the input rather than parsing it. I think it should work fine on regular date objects as there is no _isUTC member.
Contributor
There was a problem hiding this comment.
I think you might mean input._isUTC instead of moment._isUTC. The moment global does not have an _isUTC flag on it, only instances have the flag. There is a function available if you want to typecheck moment instances, moment.isMoment. However, you said that a moment's _isUTC flag is ignored when you call the moment function on it. Maybe the true bug lies in the moment function.
Member
|
Yeah, I agree, if https://github.com/timrwood/moment/blob/71eda19de4a277b76419d18f233ac4877bf801f2/moment.js#L416 should change to something like this: var isUTC;
...
if (moment.isMoment(input)) {
date = new Date(+input._d);
isUTC = input._isUTC;
}
...
return new Moment(date, isUTC); |
timrwood
added a commit
that referenced
this pull request
Apr 8, 2012
This was referenced Apr 24, 2012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears when you are working with two moment objects and you take the diff, the input moment's _isUTC is ignored when you parse the input into inputMoment. I've done a check to see if it looks like a moment object (by checking the _isUTC to see if it is defined) and if it is, then it just copies the input rather than parsing it. I think it should work fine on regular date objects as there is no _isUTC member.