Use import attributes rather than json assertions #24
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for starting the fix. There's an additional consideration - import attributes is only supported from node v18.20 and node v20.10 onwards. This means the package would probably need to support both versions. Will create a branch of this to handle the different conditions. I was also considering dropping support for Node 16 since it is now EOL, so this seems like a good chance to do so. |
This was referenced Aug 28, 2024
This was referenced Sep 7, 2024
This was referenced Sep 14, 2024
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix from #21.
Not going to mark it as closed as I didn't test it, but it should fix it.