Skip to content

[SEG] Comments#251

Merged
TonyBagnall merged 19 commits intotime-series-machine-learning:ajb/segmentationfrom
Moonzyyy:ajb/segmentation
Jul 8, 2024
Merged

[SEG] Comments#251
TonyBagnall merged 19 commits intotime-series-machine-learning:ajb/segmentationfrom
Moonzyyy:ajb/segmentation

Conversation

@Moonzyyy
Copy link
Contributor

@Moonzyyy Moonzyyy commented Jul 1, 2024

What does this implement/fix? Explain your changes

Added comments, preparing for tomorrow's meeting.

@tsml-actions-bot
Copy link
Contributor

Thank you for contributing to tsml-eval

I did not find any labels to add based on the title.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Stop automatic pre-commit fixes (always disabled for drafts)

@Moonzyyy Moonzyyy marked this pull request as ready for review July 1, 2024 15:57
@Moonzyyy
Copy link
Contributor Author

Moonzyyy commented Jul 2, 2024

Just moved my working folder to _wip and also changed segmentation to series transformer. Had a massive error happening with top down approach which is also now fixed.

@MatthewMiddlehurst
Copy link
Member

The old versions seem to be in the package still, you can see both in the diff.

@MatthewMiddlehurst
Copy link
Member

Also FYI, tests do not run when PRing into branches other than main currently.

@Moonzyyy
Copy link
Contributor Author

Moonzyyy commented Jul 2, 2024

The old versions seem to be in the package still, you can see both in the diff.

Apologies! Should all be removed now.

Copy link
Member

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets get this in and we can take a look locally, might want to restructure it a bit

@TonyBagnall TonyBagnall merged commit b69aeec into time-series-machine-learning:ajb/segmentation Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants