frozen options bug #273
Merged
frozen options bug #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
thank you for finding this @dpep ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 380 380
=========================================
Hits 380 380 ☔ View full report in Codecov by Sentry. |
tilo
reviewed
Mar 9, 2024
| options = {chunk_size: 1}.freeze | ||
| generated_options = SmarterCSV.process_options(options) | ||
| expect(generated_options[:chunk_size]).to eq 1 | ||
| end |
tilo
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Tilo,
smarter_csv modifies the options hash before dup-ing, which explodes when the options hash is frozen. This happens, specifically, when setting
invalid_byte_sequence. I did a little tidying up while I was at it 🎯 😉