skiplist: Fix undefined behavior in arena drop#24
Merged
Conversation
The Vec must be deallocated with the same pointer alignment and capacity as it is created. Signed-off-by: Brian Anderson <andersrb@gmail.com>
BusyJay
approved these changes
Oct 21, 2020
Member
|
Perhaps we can also add miri check in CI. |
skyzh
approved these changes
Oct 21, 2020
skyzh
left a comment
skyzh
left a comment
Member
There was a problem hiding this comment.
Thanks! I'll add miri check later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vec must be deallocated with the same pointer alignment and capacity as it
is created.
Signed-off-by: Brian Anderson andersrb@gmail.com
Found with miri cc @RalfJung