Remove use of text/template #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of text/template inhibits dead code elimination, see golang/go#62024 Building with go1.22.1 via `go build -v -trimpath -ldflags '-d -w'` results in binary size reduction from 2704725 to 1652718 bytes (-39%).
|
Building with outdated go1.18.2 results in binary size reduction from 2351385 to 1495254 (-36%). |
tianon
approved these changes
Mar 20, 2024
That's a tough call - the code is pretty slick 😄 Thank you for the utility. |
This was referenced Mar 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of text/template inhibits dead code elimination, see golang/go#62024
Building with go1.22.1 via
go build -v -trimpath -ldflags '-d -w'results in binary size reduction from 2704725 to 1652718 bytes (-39%).