Skip to content

Conversation

@zargold
Copy link

@zargold zargold commented Oct 8, 2025

At present the documentation (and possibly the tokens functionality for iOS/Android @Muhieddine-El-Kaissi / @brian-terczynski please confirm?) still uses this deprecated repo for controlling the tokens.

Specifically, this repo is hosted by netlify: https://thumbprint-tokens.netlify.app and this is the source that thumbprint.design uses to generate (via a GraphQL request) the page which documents all of our tokens: https://thumbprint.design/tokens/scss#section-line-height

We should make sure that all dependents on this switch to the one in the frontend monorepo (thumbtack/frontend/lib/thumbprint-tokens) but until that happens, it may be necessary to dual write changes to this and that repo.

@Muhieddine-El-Kaissi
Copy link
Contributor

Correct we still use this repo. does the other one supports SPM?

@zargold
Copy link
Author

zargold commented Oct 8, 2025

https://deploy-preview-85--thumbprint-tokens.netlify.app
The deploy preview shows the new token with this query:

# Write your query or mutation here
{
  version
  categories(platform: "javascript") {
    name
    description
    tokens {
      platforms {
        javascript {
          name
          value
          description
        }
        javascript {
          value
        }
      }
      format
      group
      deprecated
    }
  }
}

@zargold
Copy link
Author

zargold commented Oct 8, 2025

I'm guessing:

does the other one supports SPM?

SPM meant [Swift Package Manager] if what you need is for there to be a GraphQL query that allows you to download the tokens then I think we should more or less have that.

Also, netlify complains about this repo using:

  • deprecated Node-10
  • deprecated Ubuntu version 20 (it says this will no longer be possible for deploys in 2026).

@Muhieddine-El-Kaissi
Copy link
Contributor

I'm guessing:

does the other one supports SPM?

SPM meant [Swift Package Manager] if what you need is for there to be a GraphQL query that allows you to download the tokens then I think we should more or less have that.

Also, netlify complains about this repo using:

  • deprecated Node-10
  • deprecated Ubuntu version 20 (it says this will no longer be possible for deploys in 2026).

we need to add Package.swift in there to support spm https://github.com/thumbtack/thumbprint-tokens/pull/69/files#diff-f913940c58e8744a2af1c68b909bb6383e49007e6c5a12fb03104a9006ae677e
how urgent is to do the migration?

@zargold
Copy link
Author

zargold commented Oct 8, 2025

I'd say it's possibly already out-of-date in a way because it still uses Node-10 (which is no longer receiving security etc updates).

In terms of the deployment it might require us to urgently do at least some updates because:

Your project is using the Focal build image which will be deprecated starting January 1, 2026.

This is the ubuntu version (when I tried to deploy with the next [non-deprecated] version the deployment failed.

@zargold zargold force-pushed the raz/WEB-1023/line-height branch from 6806818 to 82da825 Compare October 9, 2025 20:20
@danoc danoc removed their request for review November 12, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants