Skip to content

GR-10830: Add the Clear style to ThumbprintButton #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexroussiereTT wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GR-10830: Add the Clear style to ThumbprintButton #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c49a7f1
GR-10830: Add the Clear style to ThumbprintButton
alexroussiereTT Jan 4, 2023
92be712
Revert wild import
alexroussiereTT Jan 5, 2023
1d4fcfe
removed test layout
alexroussiereTT Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion thumbprint/src/main/java/com/thumbtack/thumbprint/views/button/ThumbprintButton.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import android.graphics.Typeface.BOLD
import android.graphics.drawable.Drawable
import android.os.Build
import android.util.AttributeSet
import android.util.TypedValue
import androidx.annotation.DimenRes
import androidx.annotation.DrawableRes
import androidx.appcompat.view.ContextThemeWrapper
Expand Down Expand Up @@ -50,7 +51,8 @@ class ThumbprintButton @JvmOverloads constructor(
SECONDARY(1, R.color.button_secondary_text_color_selector, R.color.tp_blue),
TERTIARY(2, R.color.button_tertiary_text_color_selector, R.color.tp_black_300),
CAUTION(3, R.color.button_caution_text_color_selector, R.color.tp_red),
SOLID(4, R.color.button_solid_text_color_selector, R.color.tp_black);
SOLID(4, R.color.button_solid_text_color_selector, R.color.tp_black),
CLEAR(5, R.color.button_clear_text_color_selector, R.color.tp_blue);
}

private val thumbprintButtonAttributes = ThumbprintButtonAttributes(context, attrs)
Expand Down Expand Up @@ -220,6 +222,15 @@ class ThumbprintButton @JvmOverloads constructor(
} else {
R.drawable.button_solid_background
}
ThumbprintButtonType.CLEAR ->
with(TypedValue()) {
context.theme.resolveAttribute(
R.attr.selectableItemBackground,
this,
true
)
resourceId
}
}
setBackgroundResource(backgroundId)

Expand Down
1 change: 1 addition & 0 deletions thumbprint/src/main/res/values/attrs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
<enum name="tertiary" value="2" />
<enum name="caution" value="3" />
<enum name="solid" value="4" />
<enum name="clear" value="5" />
</attr>
<attr name="isLoading" format="boolean" />
<attr name="isEnabled" format="boolean" />
Expand Down