Skip to content

TransformControls: Rename getGizmo() to getHelper(). #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2024
Merged

TransformControls: Rename getGizmo() to getHelper(). #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d111ec5
TransformControls: Rename getGizmo() to getHelper().
Methuselah96 Sep 24, 2024
2773a44
Update three.js
Methuselah96 Sep 24, 2024
7e1c510
Add examples
Methuselah96 Sep 24, 2024
7c325a3
Update patch and delete examples
Methuselah96 Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples-testing/changes.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,7 +1061,7 @@ index b6479e9f..2e8f3dad 100644

controls.rotateSpeed = 1.0;
diff --git a/examples-testing/examples/misc_controls_transform.ts b/examples-testing/examples/misc_controls_transform.ts
index 8b8c3f45..a4a47907 100644
index 6f7793d3..d7d327e9 100644
--- a/examples-testing/examples/misc_controls_transform.ts
+++ b/examples-testing/examples/misc_controls_transform.ts
@@ -3,8 +3,8 @@ import * as THREE from 'three';
Expand Down Expand Up @@ -11967,7 +11967,7 @@ index c68d6974..996aedd4 100644
context.fillRect(0, 1, 2, 1);

diff --git a/examples-testing/examples/webgl_shadowmap_progressive.ts b/examples-testing/examples/webgl_shadowmap_progressive.ts
index b847cb8b..6136a9d8 100644
index e9f6b5b9..6ad8a650 100644
--- a/examples-testing/examples/webgl_shadowmap_progressive.ts
+++ b/examples-testing/examples/webgl_shadowmap_progressive.ts
@@ -9,17 +9,17 @@ import { ProgressiveLightMap } from 'three/addons/misc/ProgressiveLightMap.js';
Expand Down Expand Up @@ -15914,7 +15914,7 @@ index 50a99041..b5925eb1 100644

const texture = new THREE.VideoTexture(video);
diff --git a/examples-testing/examples/webxr_xr_controls_transform.ts b/examples-testing/examples/webxr_xr_controls_transform.ts
index 18829ad1..0bf58c74 100644
index 6e690141..ee8cabbd 100644
--- a/examples-testing/examples/webxr_xr_controls_transform.ts
+++ b/examples-testing/examples/webxr_xr_controls_transform.ts
@@ -3,14 +3,14 @@ import { TransformControls } from 'three/addons/controls/TransformControls.js';
Expand Down
2 changes: 1 addition & 1 deletion three.js
Open in desktop
Submodule three.js updated 12 files
+2 −2 docs/examples/en/controls/TransformControls.html
+1 −1 editor/js/Viewport.js
+1 −1 examples/jsm/controls/TransformControls.js
+1 −1 examples/misc_controls_transform.html
+1 −1 examples/webgl_animation_skinning_ik.html
+1 −1 examples/webgl_geometry_spline_editor.html
+1 −1 examples/webgl_modifier_curve.html
+1 −1 examples/webgl_modifier_curve_instanced.html
+2 −2 examples/webgl_shadowmap_progressive.html
+1 −1 examples/webgpu_tsl_compute_attractors_particles.html
+1 −1 examples/webxr_xr_controls_transform.html
+22 −0 src/renderers/webgl/WebGLTextures.js
6 changes: 3 additions & 3 deletions types/three/examples/jsm/controls/TransformControls.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,10 @@ declare class TransformControls extends Controls<TransformControlsEventMap> {
constructor(camera: Camera, domElement?: HTMLElement);

/**
* Returns the visual representation of the controls. Add the gizmo to your scene to visually transform the attached
* 3D object.
* Returns the visual representation of the controls. Add the helper to your scene to visually transform the
* attached 3D object.
*/
getGizmo(): TransformControlsRoot;
getHelper(): TransformControlsRoot;

pointerHover(pointer: PointerEvent | null): void;
pointerDown(pointer: PointerEvent | null): void;
Expand Down