Skip to content

Addons: Remove SDFGeometryGenerator. #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Addons: Remove SDFGeometryGenerator. #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec16c4f
Update three.js
Methuselah96 Sep 22, 2024
a5f86d1
Add examples
Methuselah96 Sep 22, 2024
efbc6a0
Update patch and delete examples
Methuselah96 Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions examples-testing/changes.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4108,37 +4108,6 @@ index a603710b..74676e45 100644
if (event.isPrimary === false) return;

document.removeEventListener('pointermove', onPointerMove);
diff --git a/examples-testing/examples/webgl_geometry_sdf.ts b/examples-testing/examples/webgl_geometry_sdf.ts
index fa5dba10..9ce7da93 100644
--- a/examples-testing/examples/webgl_geometry_sdf.ts
+++ b/examples-testing/examples/webgl_geometry_sdf.ts
@@ -4,7 +4,16 @@ import { SDFGeometryGenerator } from 'three/addons/geometries/SDFGeometryGenerat
import Stats from 'three/addons/libs/stats.module.js';
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';

-let renderer, stats, meshFromSDF, scene, camera, clock, controls;
+let renderer: THREE.WebGLRenderer,
+ stats: Stats,
+ meshFromSDF: THREE.Mesh<
+ THREE.BufferGeometry,
+ THREE.MeshBasicMaterial | THREE.MeshDepthMaterial | THREE.MeshNormalMaterial
+ >,
+ scene: THREE.Scene,
+ camera: THREE.OrthographicCamera,
+ clock: THREE.Clock,
+ controls: OrbitControls;

const settings = {
res: 4,
@@ -12,7 +21,7 @@ const settings = {
autoRotate: true,
wireframe: true,
material: 'depth',
- vertexCount: '0',
+ vertexCount: 0,
};

// Example SDF from https://www.shadertoy.com/view/MdXSWn -->
diff --git a/examples-testing/examples/webgl_geometry_shapes.ts b/examples-testing/examples/webgl_geometry_shapes.ts
index f1d00f01..2042c353 100644
--- a/examples-testing/examples/webgl_geometry_shapes.ts
Expand Down
2 changes: 1 addition & 1 deletion three.js
Open in desktop
Submodule three.js updated 20 files
+3 −3 .github/workflows/codeql-code-scanning.yml
+0 −70 docs/examples/en/geometries/SDFGeometryGenerator.html
+123 −0 docs/examples/ko/controls/MapControls.html
+0 −72 docs/examples/zh/geometries/SDFGeometryGenerator.html
+2 −3 docs/list.json
+0 −1 examples/files.json
+0 −144 examples/jsm/geometries/SDFGeometryGenerator.js
+ − examples/screenshots/webgl_geometry_sdf.jpg
+0 −212 examples/webgl_geometry_sdf.html
+1 −1 examples/webgpu_instance_mesh.html
+1 −1 examples/webgpu_materials.html
+8 −10 examples/webgpu_performance_renderbundle.html
+69 −69 package-lock.json
+90 −93 src/nodes/TSL.js
+0 −1 src/nodes/accessors/MaterialNode.js
+4 −4 src/nodes/display/ColorSpaceFunctions.js
+12 −12 src/nodes/display/ToneMappingFunctions.js
+44 −0 src/renderers/webgl/WebGLAttributes.js
+10 −10 src/renderers/webgpu/nodes/BasicNodeLibrary.js
+10 −10 src/renderers/webgpu/nodes/StandardNodeLibrary.js
16 changes: 0 additions & 16 deletions types/three/examples/jsm/geometries/SDFGeometryGenerator.d.ts
View file
Open in desktop

This file was deleted.