Remove caching support in HighVoltage #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgalarza
force-pushed
the
dg-remove-caching
branch
from
f1702f2 to
1d124fb
Compare
|
LGTM Is there some other form of caching we should recommend instead? |
Contributor
Author
|
Good question @bernerdschaefer. Perhaps instead of removing the section in the README about caching altogether, we keep the links to |
Contributor
Author
|
Updated the README to restore our notes on caching and linking to the Rails guides. WDUT @bernerdschaefer? |
|
👍 |
Page caching was deprecated in fac899f. In preparation to move towards a 3.0 release with Rails 5.0 support, we are removing built in caching support.
dgalarza
force-pushed
the
dg-remove-caching
branch
from
1c93fa5 to
e565885
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page caching was deprecated in fac899f. In preparation to move towards a 3.0 release with
Rails 5.0 support, we are removing built in caching support. Specifically the
actionpack-action_cachingandactionpack-page_cachingdo not support Rails 5 which makes it harder for us to push forward.