✨ Support eval_gemfile #248

pboling · 2025-02-03T15:13:24Z

Fixes Appraisal doesn't support eval_gemfile #154

_{Please help me support open source by sponsoring me - @pboling}

pboling · 2025-02-03T15:23:49Z

This sits on top of #250, since that PR fixes CI, and adds more Ruby engines and versions to the matrix.

pboling · 2025-02-03T15:24:23Z

spec/acceptance/eval_gemfile_spec.rb

+  end
+
+  def build_gemspec(path = ".")
+    Dir.mkdir("tmp/stage/#{path}") rescue nil


This was an existing pattern in the tests I merely copied.

pboling · 2025-02-03T15:24:28Z

spec/acceptance/eval_gemfile_spec.rb

+  end
+
+  def build_modular_gemfile
+    Dir.mkdir("tmp/stage/gemfiles") rescue nil


This was an existing pattern in the tests I merely copied.

- thoughtbot/appraisal#248

pboling · 2025-02-12T17:21:14Z

ping @nickcharlton 🔶

n-rodriguez · 2025-02-19T20:02:28Z

@pboling

I think the test suite was already broken before I made any changes

I don't think so, see: https://github.com/thoughtbot/appraisal/actions/runs/10999060013, but it might be due to a change in Bundler 😢

pboling · 2025-02-20T06:05:14Z

Interesting. Actually there may only be a few minor failures. From the Ruby 3.4 build:

            expected: 
"# This file was generated by Appraisal\n\nsource \"[https://rubygems.org\](https://rubygems.org/)"\n\nruby({:file=>\".ruby-version\"})\n\ngem \"appraisal\", :path => \"/home/runner/work/appraisal/appraisal\"\n"
            got:
"# This file was generated by Appraisal\n\nsource \"[https://rubygems.org\](https://rubygems.org/)"\n\n:ruby({file => \".ruby-version\"})\n\ngem \"appraisal\", :path => \"/home/runner/work/appraisal/appraisal\"\n"

The difference is there are spaces around the => for :file in got, but not expected. Oddly the spaces around => for :path are the same in both...

Also there is a semicolon before ruby for expected, but not for got. This seems like tests may not have been modified properly according to the way hashes print in Ruby 3.4?

pboling · 2025-02-20T18:51:06Z

@nickcharlton I tihnk some of the failures were legit broken stuff. I've fixed pretty much everything (and done some other things too) in a new PR:
#249

This reverts commit 92d5134.

- https://dev.to/galtzo/matrix-ruby-gem-bundler-etc-4kk7

n-rodriguez · 2025-02-20T22:16:39Z

@pboling thank you!
@nickcharlton LGTM

- Support debug for debugging with Ruby >= 2.7 - Support byebug for debugging with Ruby < 2.7

- #250 (comment)

…d matrix - all current jruby and truffleruby are compatible with Ruby 3.1 at minimum, thus are supported by latest bundler

- Use strip_heredoc uniformly in acceptance tests

- #250 (comment)

- Differences in handling of whitespace between versions of Ruby are often seen as minor, and go unnoticed unless tests explicitly test white space as appraisal's test suite does.

pboling · 2025-02-21T22:45:44Z

Rebased on top of the PR that fixes the build (#250) down to Ruby 2.7.

- thoughtbot/appraisal#250 - thoughtbot/appraisal#248

- Ruby < 2 compat

- Possibly due to bundler issue on MRI and JRuby engines - ruby/rubygems#8518

- Fixes #154

pboling · 2025-02-24T20:02:45Z

Rebased on my lts branch again, which should make the build green here.

hound · 2025-02-24T20:02:45Z

lib/appraisal/task.rb

-      desc "Run the given task for all appraisals"
-      task appraisal: "appraisal:all"
+      desc("Run the given task for all appraisals")
+      task(:appraisal => "appraisal:all")


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.

hound · 2025-02-24T20:02:45Z

lib/appraisal/task.rb

+        task(:all) do
          ARGV.shift
-          exec "bundle exec appraisal rake #{ARGV.join(' ')}"
+          exec("bundle exec appraisal rake #{ARGV.join(" ")}")


Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.

hound · 2025-02-24T20:02:45Z

lib/appraisal/task.rb

-              exec "bundle exec appraisal #{appraisal.name} rake #{ARGV.join(' ')}"
+              warn("`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \
+                "Please use `appraisal #{appraisal.name} rake #{ARGV.join(" ")}`.")
+              exec("bundle exec appraisal #{appraisal.name} rake #{ARGV.join(" ")}")


Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
Metrics/LineLength: Line is too long. [84/80]

hound · 2025-02-24T20:02:45Z

lib/appraisal/task.rb

-                "Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`."
-              exec "bundle exec appraisal #{appraisal.name} rake #{ARGV.join(' ')}"
+              warn("`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \
+                "Please use `appraisal #{appraisal.name} rake #{ARGV.join(" ")}`.")


Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
Metrics/LineLength: Line is too long. [83/80]

hound · 2025-02-24T20:02:45Z

lib/appraisal/task.rb

-              warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " +
-                "Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`."
-              exec "bundle exec appraisal #{appraisal.name} rake #{ARGV.join(' ')}"
+              warn("`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \


Metrics/LineLength: Line is too long. [103/80]

hound · 2025-02-24T20:02:46Z

lib/appraisal/utils.rb

    end

+    # Appraisal needs to print Gemfiles in the oldest Ruby syntax that is supported by Appraisal.
+    # This means formatting Hashes as Rockets, until support for Ruby 1.8 is dropped.


Metrics/LineLength: Line is too long. [85/80]

hound · 2025-02-24T20:02:46Z

lib/appraisal/utils.rb

      end
    end

+    # Appraisal needs to print Gemfiles in the oldest Ruby syntax that is supported by Appraisal.


Metrics/LineLength: Line is too long. [97/80]

hound · 2025-02-24T20:02:46Z

lib/appraisal/utils.rb


        if enclosing_object
-          "{ #{items.join(', ')} }"
+          "{ #{items.join(", ")} }"


Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.

hound · 2025-02-24T20:02:46Z

lib/appraisal/utils.rb

+    end
+
+    # Appraisal needs to print Gemfiles in the oldest Ruby syntax that is supported by Appraisal.
+    # Otherwise, a project would not be able to use Appraisal to test compatibility


Metrics/LineLength: Line is too long. [83/80]

hound · 2025-02-24T20:02:46Z

lib/appraisal/utils.rb

+      Gem::Version.create(Bundler::VERSION) > Gem::Version.create("2.4.22")
+    end
+
+    # Appraisal needs to print Gemfiles in the oldest Ruby syntax that is supported by Appraisal.


Metrics/LineLength: Line is too long. [97/80]

pboling · 2025-03-19T20:36:58Z

@nickcharlton ping!

nickcharlton · 2025-03-25T12:50:49Z

I haven't looked at this properly yet, because it's stacked on all of the other work. But once we break that out, we can come back to this and get it merged in!

pboling · 2025-03-26T19:02:01Z

Now that I'm starting to use this more heavily, I've discovered major side benefits of eval_gemfile. I call gemfiles invoked by eval_gemfile "modular gemfiles".

Single source of truth (when possible)
Don't need to run appraisal update if the changes are only to a modular gemfile.

You can see how powerful they are here:

As an example I added the gem minitest-retry to my modular gemfile at gemfiles/modular/mini_testing.gemfile, and I didn't need to re-bundle my Appraisals!

CC @nickcharlton

pboling · 2025-07-11T03:53:01Z

It is clear that the community needs these fixes.

PeevRb/dumpcar#49

I am personally implementing this branch across dozens of major projects currently.

Would Thoughtbot consider adding me as a maintainer?

Part of my reluctance in splitting this into small PRs is the long intervals spent waiting for attention from existing maintainers on the two existing PRs I submitted (which grew over time, but started out pretty small).

If the cycle time holds the split PRs may not all get merged for years, and the community will have fully splintered into hard coded dependencies on forks, which will invariably result in resistance to switching back to mainline and getting further upgrades (not least because git dependencies do not show up in many tools that check for out of date dependencies).

This tool is too important to let it die, and it might make more sense to create an appraisal org, and hard fork the gem to appraisal2, so it is untethered from thoughtbot. Status quo is not working well.

n-rodriguez · 2025-07-11T11:36:30Z

This tool is too important to let it die

I do agree

it might make more sense to create an appraisal org

Why not if it helps adding maintainers to the project. On the other hand it should not be difficult to add maintainers to the current project in thoughtbot org.

hard fork the gem to appraisal2, so it is untethered from thoughtbot.

I don't think this is a good idea. I would prefer transferring appraisal gem to appraisal org rather than doing a hard fork to avoid multiplication of official repos.

@nickcharlton let us know if we can do anything to get this PR merged. thank you!

pboling · 2025-07-11T17:06:18Z

I agree that it could live on under Thoughtbot, but only just. I don't think Thoughtbot has the level of corporate interest in this project to sustain it. If they were aware of the issue and wanted to, something would have been done already.

They've already effectively killed this project twice.

First when it remained incompatible with GHA for years, I had to rip it out of projects I migrated to GHA from other CIs.

Second, after they fixed it to work with GHA, they dropped support for old Rubies, which coupled with the general lack of development, meant my choices were to rip it out again, or fix it.

It isn't clear Thoughtbot wants this project attached to them anymore aside from a historical byline. I think it is likely that the bulk of the company's interest lies outside of Ruby now... which is perfectly valid. They don't have to hold onto it forever.

Perhaps it is time for thoughtbot to move the project to a discrete org. I'll go ahead and create one in case the ball moves in that direction, and I'll sent owner invites to invested parties.

pboling · 2025-07-11T17:19:26Z

Also, thinking more about this, appraisal2, as a gem hard fork, does have a direct path to reunification. If the two converge, appraisal2 can depend on appraisal, and have a post install message to revert the dependency back to the original. This way the upgrade path will be advertized properly by things like bundle outdated when the new version is released directing people back. I think that's actually better than the git chaos which has no tracking, and no central manner of communicating about the tool's status.

So to that end I'll fork this to the new org, and rename it to appraisal2.

It will speed up all of my builds
save energy, and hence the planet, a little bit
In fact, because of the git dependency I have been forced to add and then remove the appraisal gem to each individal appraisal (with remove_gem)... this will simplify things significantly!

🚀

pboling · 2025-07-11T17:29:57Z

For better or worse:
https://github.com/appraisal-rb/appraisal2

@nickcharlton @n-rodriguez @deivid-rodriguez you've all been invited to the org, as the top three contributors to this project who had any involvement in the last several years.

pboling · 2025-07-11T17:56:46Z

I just realized that another mental blocker I had for redoing this PR in small parts is I actually already did a significant additional amount of work on top of it, fixing many other issues.

All of this work is going to be in appraisal2, and it all starts with this PR:

appraisal-rb#1

pboling commented Feb 3, 2025

View reviewed changes

pboling mentioned this pull request Feb 3, 2025

Appraisal doesn't support eval_gemfile #154

Open

pboling added a commit to VitalConnectInc/turbo_tests that referenced this pull request Feb 3, 2025

✨ Utilize eval_gemfile with appraisals

35d43e3

- thoughtbot/appraisal#248

pboling mentioned this pull request Feb 18, 2025

Appraisal v3 #204

Open

pboling mentioned this pull request Feb 20, 2025

eval_gemfile + LTS support #249

Closed

pboling added 2 commits February 21, 2025 04:20

Revert "Drop MRI 1.8.7-2.2 support (#158)"

9860cb9

This reverts commit 92d5134.

💚 Fix bundler versions per Ruby version

14f36cd

- https://dev.to/galtzo/matrix-ruby-gem-bundler-etc-4kk7

n-rodriguez approved these changes Feb 20, 2025

View reviewed changes

pboling added 15 commits February 21, 2025 05:34

💚 Fix ruby declaration in Gemfile when on ruby-head

79a6de1

- Support debug for debugging with Ruby >= 2.7 - Support byebug for debugging with Ruby < 2.7

🚨 Address code review from @n-rodriguez

2d022fc

- #250 (comment)

👷 Add Rubies 2.7, 2.6, 2.5, 2.4, 2.3, 2.2, 2.1, 2.0, 1.9, 1.8 to buil…

df41df2

…d matrix - all current jruby and truffleruby are compatible with Ruby 3.1 at minimum, thus are supported by latest bundler

♻️ Use .rspec to dry spec file headers

1a5b85d

- Use strip_heredoc uniformly in acceptance tests

🚨 Address code review from @n-rodriguez

a19e707

- #250 (comment)

🐛 Fixes for Ruby 2.7 compat

e1673bc

- Differences in handling of whitespace between versions of Ruby are often seen as minor, and go unnoticed unless tests explicitly test white space as appraisal's test suite does.

👷 add Ruby 3.4

4ec2725

🐛 Fix inconsistent indentation

594690d

📝 Documentation

386ddb6

💚 Fix inconsistent indentation in spec fixtures

7a2ec8e

🚨 Lint lock update

f722561

👷 Add Ruby 2.6

12002da

✏️ Lookahead != Lookbehind

df71fbb

✏️ Fix typo in documentation

5fcfb43

👷 Remove Ruby 2.6 from CI (to be added back in another PR)

975ded0

📝 Documentation

46d71e6

pboling added a commit to galtzo-floss/stone_checksums that referenced this pull request Feb 22, 2025

➕ gem "appraisal", github: "pboling/appraisal", branch: "galtzo"

3fbfa17

- thoughtbot/appraisal#250 - thoughtbot/appraisal#248

pboling mentioned this pull request Feb 22, 2025

➕ gem "appraisal", github: "pboling/appraisal", branch: "galtzo" galtzo-floss/stone_checksums#1

Merged

pboling added 12 commits February 25, 2025 00:13

🐛 Ruby 1.8 compat: Replace __dir__ with File.dirname(__FILE__)

c07c0c9

🚨 Lint lock update

1ceb8ab

🐛 Ruby < 3.0 compat: Bifurcate the Modern Double Splat

8bffc9d

🐛 Ruby < 3.0 compat: Bifurcate the Modern Double Splat (redux)

f3595ab

🐛 Ruby < 3.0 compat: Bifurcate the Modern Double Splat (redux deux)

f582740

🐛 Ruby < 3.0 compat: Bifurcate the Modern Double Splat (tiga)

1579ad0

🐛 Ruby < 3.0 compat: Bifurcate the Modern Double Splat (empat)

a524ead

🚨 Style/SymbolArray: EnforcedStyle: brackets

df2a1e9

- Ruby < 2 compat

💚 Pend spec failure

0a02c86

- Possibly due to bundler issue on MRI and JRuby engines - ruby/rubygems#8518

💚 skip tests that are known to fail on old bundler versions

be18441

💚 turn off truffleruby-head for now

198a324

✨ Support eval_gemfile

c353e3e

- Fixes #154

hound bot reviewed Feb 24, 2025

View reviewed changes

wwahammy mentioned this pull request Jun 7, 2025

Update appraisal so it works with Ruby-lsp PeevRb/dumpcar#49

Merged

pboling mentioned this pull request Jul 11, 2025

✨ Support eval_gemfile & other stories appraisal-rb/appraisal2#1

Merged

pboling closed this by deleting the head repository Jul 28, 2025

Uh oh!

✨ Support eval_gemfile #248

✨ Support eval_gemfile #248

Uh oh!

Conversation

pboling commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pboling commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pboling Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

pboling Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

pboling commented Feb 12, 2025

Uh oh!

n-rodriguez commented Feb 19, 2025

Uh oh!

pboling commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pboling commented Feb 20, 2025

Uh oh!

n-rodriguez commented Feb 20, 2025

Uh oh!

pboling commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pboling commented Feb 24, 2025

Uh oh!

hound bot Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

pboling commented Mar 19, 2025

Uh oh!

nickcharlton commented Mar 25, 2025

Uh oh!

pboling commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pboling commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n-rodriguez commented Jul 11, 2025

Uh oh!

pboling commented Jul 11, 2025

Uh oh!

pboling commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pboling commented Feb 3, 2025 •

edited

Loading

pboling commented Feb 3, 2025 •

edited

Loading

pboling commented Feb 20, 2025 •

edited

Loading

pboling commented Feb 21, 2025 •

edited

Loading

pboling commented Mar 26, 2025 •

edited

Loading

pboling commented Jul 11, 2025 •

edited

Loading

pboling commented Jul 11, 2025 •

edited

Loading