Develop

.github/workflows/_tests-template.yml

@@ -7,6 +7,12 @@ on:
         required: true
         type: string
 
+permissions:
+  contents: read
+  pull-requests: write
+  checks: write
+  id-token: write
+
 jobs:
   build:
     runs-on: ubuntu-latest

.github/workflows/ci.yml

@@ -6,7 +6,13 @@ on:
   schedule:
     - cron: '0 2 * * *'  # each day at 2 AM UTC
   workflow_dispatch:     # manual trigger
-
+
+permissions:
+  contents: read
+  pull-requests: write
+  checks: write
+  id-token: write
+
 jobs:
   build:
     runs-on: ubuntu-latest

.github/workflows/deploy-nuget.yml

@@ -3,6 +3,12 @@ name: "Deploy Nuget"
 on:  
   workflow_dispatch: # Manual trigger
 
+permissions:
+  contents: read
+  pull-requests: write
+  checks: write
+  id-token: write
+
 jobs:
   build:
     runs-on: ubuntu-latest

.github/workflows/tests-alphavantage.yml

@@ -6,7 +6,13 @@ on:
   workflow_dispatch: # Manual trigger
   schedule:
     - cron: '0 2 * * *'  # Runs nightly at 2 AM UTC on main branch
-
+
+permissions:
+  contents: read
+  pull-requests: write
+  checks: write
+  id-token: write
+
 jobs:
   run-test:
     uses: ./.github/workflows/_tests-template.yml

.github/workflows/tests-datahub.yml

@@ -7,6 +7,12 @@ on:
   schedule:
     - cron: '0 2 * * *'  # Runs nightly at 2 AM UTC on main branch
 
+permissions:
+  contents: read
+  pull-requests: write
+  checks: write
+  id-token: write
+
 jobs:
   run-test:
     uses: ./.github/workflows/_tests-template.yml

.github/workflows/tests-xetra.yml

@@ -7,6 +7,12 @@ on:
   schedule:
     - cron: '0 2 * * *'  # Runs nightly at 2 AM UTC on main branch
 
+permissions:
+  contents: read
+  pull-requests: write
+  checks: write
+  id-token: write
+
 jobs:
   run-test:
     uses: ./.github/workflows/_tests-template.yml

.github/workflows/tests-yahoo.yml

@@ -7,6 +7,12 @@ on:
   schedule:
     - cron: '0 2 * * *'  # Runs nightly at 2 AM UTC on main branch
 
+permissions:
+  contents: read
+  pull-requests: write
+  checks: write
+  id-token: write
+
 jobs:
   run-test:
     uses: ./.github/workflows/_tests-template.yml

release-notes/v1.0.11.md

@@ -0,0 +1,5 @@
+### What's Changed
+
+* Fix: Making Polly AsyncPolicy optional.
+
+

src/Finance.NET.csproj

@@ -12,7 +12,7 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
 	<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
 	<PackageId>Finance.NET</PackageId>
-	<Version>1.0.10</Version>
+	<Version>1.0.11</Version>
 	<Authors>Thorsten Alpers</Authors>
 	<Owners>Thorsten Alpers</Owners>
 	<Description>A .NET library for retrieving real-time and historical financial data from Yahoo Finance and other popular sources.</Description>

src/Services/AlphaVantageService.cs

@@ -18,15 +18,51 @@
 
 namespace Finance.Net.Services;
 /// <inheritdoc />
-public class AlphaVantageService(ILogger<AlphaVantageService> logger,
-IHttpClientFactory httpClientFactory,
-IOptions<FinanceNetConfiguration> options,
-IReadOnlyPolicyRegistry<string> policyRegistry) : IAlphaVantageService
+public class AlphaVantageService : IAlphaVantageService
 {
-    private readonly ILogger<AlphaVantageService> _logger = logger ?? throw new ArgumentNullException(nameof(logger));
-    private readonly IHttpClientFactory _httpClientFactory = httpClientFactory ?? throw new ArgumentNullException(nameof(httpClientFactory));
-    private readonly FinanceNetConfiguration _options = options?.Value ?? throw new ArgumentNullException(nameof(options));
-    private readonly AsyncPolicy _retryPolicy = policyRegistry?.Get<AsyncPolicy>(Constants.DefaultHttpRetryPolicy) ?? throw new ArgumentNullException(nameof(policyRegistry));
+    private readonly ILogger<AlphaVantageService> _logger;
+    private readonly IHttpClientFactory _httpClientFactory;
+    private readonly FinanceNetConfiguration _options;
+    private readonly IAsyncPolicy _retryPolicy;
+
+    /// <inheritdoc />
+    public AlphaVantageService(
+        ILogger<AlphaVantageService> logger,
+        IHttpClientFactory httpClientFactory,
+        IOptions<FinanceNetConfiguration> options,
+        IReadOnlyPolicyRegistry<string>? policyRegistry = null)
+    {
+        _logger = logger ?? throw new ArgumentNullException(nameof(logger));
+        _httpClientFactory = httpClientFactory ?? throw new ArgumentNullException(nameof(httpClientFactory));
+        _options = options?.Value ?? throw new ArgumentNullException(nameof(options));
+
+        if (policyRegistry != null &&
+            policyRegistry.TryGet<IAsyncPolicy>(Constants.DefaultHttpRetryPolicy, out var found))
+        {
+            _retryPolicy = found;
+        }
+        else
+        {
+            _retryPolicy = Policy
+                .Handle<HttpRequestException>()
+                .Or<TaskCanceledException>()
+                .WaitAndRetryAsync(
+                    3,
+                    attempt => TimeSpan.FromSeconds(Math.Pow(2, attempt - 1)),
+                    (ex, ts, retryCount, ctx) =>
+                    {
+                        _logger.LogWarning(
+                            "Retry {RetryCount} wegen {Reason}, warte {Delay}s",
+                            retryCount,
+                            ex?.Message ?? "Unbekannt",
+                            ts.TotalSeconds);
+                    });
+
+            _logger.LogWarning(
+                "Retry-Policy '{PolicyKey}' nicht gefunden – verwende Default (3x Retry, Backoff).",
+                Constants.DefaultHttpRetryPolicy);
+        }
+    }
 
     /// <inheritdoc />
     public async Task<InstrumentOverview?> GetOverviewAsync(string symbol, CancellationToken token = default)

tests/Services/AlphaVantageServiceTests.cs

@@ -70,11 +70,14 @@ public void Constructor_Throws()
             _mockHttpClientFactory.Object,
             null,
             _mockPolicyRegistry.Object));
-        Assert.Throws<ArgumentNullException>(() => new AlphaVantageService(
+
+        var service = new AlphaVantageService(
             _mockLogger.Object,
             _mockHttpClientFactory.Object,
             _mockOptions.Object,
-            null));
+            null);
+
+        Assert.That(service, Is.Not.Null);
     }
 
     [Test]