Closed
Conversation
thorsten-klein
force-pushed
the
override-remotes
branch
5 times, most recently
from
03e9cb0 to
d35e837
Compare
thorsten-klein
force-pushed
the
pytest-directly
branch
2 times, most recently
from
c2fcc62 to
26fd91d
Compare
thorsten-klein
force-pushed
the
override-remotes
branch
from
d35e837 to
d12eb95
Compare
The previous test setup used subprocess calls, which did not allow to debug the tests. It also caused a mix of Python modules from the installed West package and the local source tree when running tests directly with `pytest`. The tests have been updated so that `pytest` can now be run directly and fully debugged. `pytest` can be run as follows: - `pytest` — runs tests against the installed package - `pytest -o pythonpath=src` — runs tests against the local source tree Within the tests following methods can be used to run west commands: - cmd(...): call main() with given west command and capture std (and optionally stderr) - cmd_raises(...): call main() with given west command and catch expected exception. The exception and stderr are returned by default. Optionally stdout can be captured. - cmd_subprocess(...): Run west command in a subprocess and capture stdout.
When west/app/main.py is executed directly, also the correct West modules must be imported. Therefore, the Python module search path is configured appropriately before importing any West modules.
Test that the Python module search path is prepended with correct local module path if west/app/main.py is executed directly.
Add support for a new 'import-modifications' section in the manifest. Under the 'url-replace' key, users can define search-and-replace patterns that are applied to project URLs during manifest import. This allows downstream projects to modify remote URLs, e.g. when using mirrored repositories.
Test that import-modifications feature works to override west project urls that directly specified in west manifest or imported via submanifests.
thorsten-klein
force-pushed
the
override-remotes
branch
from
d12eb95 to
bc81ddf
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.