Repository navigation
ci: run only OS-specific work on Windows and macOS pull request jobs - #7582
Conversation
Ubuntu runs every suite, so the Windows and macOS pipelines on pull requests now pass --os-specific-only: PlatformNeutral suites run only their .NET Framework TFMs (Windows), and those jobs build only the projects they test. Co-Authored-By: Claude <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
ReviewThe design is sound. Filtering on the Suggestions, none blocking:
Overall this looks good, and the CI run on this PR exercises both new paths. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThis PR narrows Windows and macOS pull request jobs while leaving Ubuntu and manual runs unchanged.
Acknowledged trade-off:
|
Ubuntu runs every test suite on every pull request, so Windows and macOS only need to cover what can behave differently on their OS. They were still building the whole CI solution and, on Windows, running every platform-neutral suite again on net10.0. macOS runners are the scarcest: on #7580 the macOS job waited 65 minutes for a runner.
Changes
--os-specific-onlypipeline switch (PipelineScope). Windows and macOS pull request jobs pass it:PlatformNeutralsuites only on their .NET Framework TFMs. That keeps the.Net4_7source-generator, assertions-generator and public-API snapshots, which only Windows can produce, and drops the net10.0 runs Ubuntu already does.PlatformNeutraloutright. This replaces the category ignore added in ci: run one general macOS job per pull request push #7578.Select projectsstep writes a solution filter that leaves out the projects of suites the job won't run. That includes the Linux-only Aspire/ASP.NET example modules,examples/andbenchmarks/. macOS builds 59 of the 87 projects. The list names what to exclude, so a new project still builds everywhere until someone adds it. Project references still build what an included project needs.workflow_dispatch) runs, which publish, are unchanged: every suite runs on every OS.Still on Windows/macOS: unit tests, ASP.NET Core, OpenTelemetry, Playwright and RPC tests, engine tests (aot.yml, plus macOS in this job), AOT and the Windows package tests.
Trade-off: OS-specific quirks inside platform-neutral suites, such as CRLF handling in code fixers on Windows, now surface on Ubuntu runs only. The net472 generator snapshots still run on Windows.
Validation
TUnit.Pipelinebuilds;--helplists the new option.dotnet restore+dotnet build -c Release -graphBuild:Trueon it: 0 errors.Summary by CodeRabbit