Repository navigation
Make unfinished dependency regression independent of scheduling - #7567
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ReviewApprove. This is a one-line test fix and I found no problems.
The PR description says it ran this in both generated and reflection modes, which is what the repo's rules ask for. Optional: the new comment could name the invariant it relies on, which is that |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
[Low impact] The PR appears safe to merge. SummaryMakes the unfinished-test regression independent of scheduling.
Reviews (2) · Last reviewed commit: "Fix unfinished dependency regression sch..." · Reviewed by Greptile |
|
Reviewed all review surfaces for 876e64c: Claude and Codex approve, Greptile reports safe to merge, and there are no inline findings or unresolved threads. Keeping the current explanatory comment: it states the unfinished-test invariant needed by this regression; naming the internal Result field is optional. Promoting to ready for CI and the ready-for-review Claude run. |
|
Review: LGTM. The old The change is test-only and small, and the comment explains why the new target is safe. It also doesn't disturb Nothing else to flag. I didn't run the tests myself; the PR description reports passing runs in both generated and reflection modes. |
876e64c to
ceb12cb
Compare
|
Review: LGTM. The change removes the timing assumption from
No design concerns. This is a test-only change that fixes the flake in #7564. |
Test3 assumed Test1 would still be running after a five-second delay, so scheduling could make the unfinished-test assertion fail. Retrieve Test3 itself instead: its result is guaranteed to be unfinished while its body runs, exercising the same guard without timing assumptions.
Closes #7564
Validation: Release/net10.0 targeted
DependsOnTests2runs pass (3 tests each) in generated and reflection modes with--maximum-parallel-tests 4, and in generated mode with one parallel slot. Existing analyzer and nullable build warnings are tracked in #7410.Summary by CodeRabbit