Skip to content

Conversation

@thomhurst
Copy link
Owner

The latest version seems to be crashing test suites with broken pipe errors

The latest version seems to be crashing test suites with broken pipe errors
Copilot AI review requested due to automatic review settings January 7, 2026 12:05
@thomhurst
Copy link
Owner Author

Summary

Downgrades Microsoft.Testing.Extensions.CodeCoverage from 18.3.1 to 18.1.0 to fix broken pipe errors.

Critical Issues

None found ✅

This is a straightforward dependency downgrade to resolve runtime crashes. The change:

  • Only modifies the package version in Directory.Packages.props
  • Does not affect any TUnit critical rules (no source gen, no API changes, no reflection)
  • Uses Microsoft.Testing.Platform ecosystem (correct, not VSTest)
  • Includes minor EOF newline fix

Verdict

APPROVE - No critical issues

The downgrade is a practical fix for a blocking runtime issue. Once the upstream bug is resolved, this can be reverted.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR downgrades the Microsoft.Testing.Extensions.CodeCoverage package from version 18.3.1 to 18.1.0 to address broken pipe errors that have been occurring in test suites with the latest version.

Key Changes:

  • Downgraded Microsoft.Testing.Extensions.CodeCoverage from 18.3.1 to 18.1.0 in centralized package management

<PackageVersion Include="Microsoft.Playwright" Version="1.57.0" />
<PackageVersion Include="Microsoft.TemplateEngine.Authoring.TemplateVerifier" Version="10.0.101" />
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.3.1" />
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.1.0" />
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version numbering for Microsoft.Testing.Extensions.CodeCoverage (18.1.0) differs significantly from other Microsoft.Testing.Extensions packages (2.0.2). This suggests CodeCoverage may follow a different versioning scheme. Consider verifying that version 18.1.0 is compatible with Microsoft.Testing.Platform version 2.0.2, as package version mismatches could cause integration issues.

Suggested change
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.1.0" />
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="2.0.2" />

Copilot uses AI. Check for mistakes.
@thomhurst
Copy link
Owner Author

Summary

Downgrades Microsoft.Testing.Extensions.CodeCoverage from 18.3.1 to 18.1.0 to fix broken pipe crashes, and adds --coverage and --report-trx arguments to pipeline test modules.

Critical Issues

None found ✅

Suggestions

Consider documenting the version issue: Since this is a workaround for a broken upstream package version, consider adding a comment in Directory.Packages.props near line 40 to document why this specific version is pinned and what issue it resolves (broken pipe errors in 18.3.1). This will help future maintainers understand when it's safe to upgrade.

Verify test coverage reporting works: The addition of --coverage and --report-trx arguments to the pipeline test modules (TestNugetPackageModule.cs:71-73 and TestAspNetCoreNugetPackageModule.cs:50-52) appears to be related to the downgrade. Ensure that coverage reporting still functions correctly with version 18.1.0.

Verdict

APPROVE - No critical issues

The downgrade is a pragmatic fix for a blocking issue. The changes are minimal and low-risk.

This was referenced Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants