Skip to content

Conversation

@thomhurst
Copy link
Owner

This PR contains the following updates:

Package Type Update Change
Polyfill nuget patch 9.4.09.4.1

Release Notes

SimonCropp/Polyfill (Polyfill)

v9.4.1

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Copilot AI review requested due to automatic review settings December 19, 2025 04:46
@thomhurst thomhurst added dependencies Pull requests that update a dependency file PATCH renovate-bot labels Dec 19, 2025
@thomhurst thomhurst enabled auto-merge (squash) December 19, 2025 04:46
@claude
Copy link
Contributor

claude bot commented Dec 19, 2025

Code Review

Overview

This PR updates the Polyfill dependency from 9.4.0 to 9.4.1. The change is minimal and appears to be a routine patch update.

⚠️ Critical Issue: Version Inconsistency

Problem: This PR only updates TUnit.Core.targets but leaves Directory.Packages.props outdated.

  • TUnit.Core.targets:11 → Updated to 9.4.1
  • Directory.Packages.props:62 → Still at 9.3.4

Impact: Since this repository uses Central Package Management (ManagePackageVersionsCentrally=true), the version in Directory.Packages.props is the authoritative source for CPM-enabled projects. The TUnit.Core.targets file uses VersionOverride for CPM projects (line 26), which should work, but there's a version skew between:

  • The centrally-managed version (9.3.4)
  • The auto-injected version for non-CPM projects (9.4.1)

Recommendation: Update Directory.Packages.props line 62 to also reference 9.4.1 to maintain consistency:

<PackageVersion Include="Polyfill" Version="9.4.1" />

Positive Aspects

✅ Patch update is low-risk
✅ Change is properly scoped to version string only
✅ Follows semantic versioning (patch bump)
✅ No code changes, only dependency version

Testing Recommendation

Since Polyfill is used for compile-time type generation on older frameworks:

  • Verify builds succeed on netstandard2.0/2.1 and .NET Framework targets
  • Ensure no breaking changes in Polyfill 9.4.1 (changelog appears empty)

Verdict

Request Changes: Please update Directory.Packages.props to match the version in TUnit.Core.targets to maintain consistency across the repository's package management.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Polyfill dependency from version 9.4.0 to 9.4.1, a patch-level update. This is an automated dependency update generated by Renovate Bot.

  • Updates the Polyfill package version reference in TUnit.Core.targets

@thomhurst thomhurst merged commit 1e2e9f0 into main Dec 19, 2025
18 of 19 checks passed
@thomhurst thomhurst deleted the renovate/_tunitpolyfillversion branch December 19, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file PATCH renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants