-
-
Notifications
You must be signed in to change notification settings - Fork 96
fix: implement linear search for custom comparers in IsEquivalentToAssertion #3368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @thomhurst's task —— View job Pull Request ReviewReviewing PR #3368 that fixes issue #3367 regarding custom comparers in Review Checklist:
📋 Review SummaryThis PR implements a fix for issue #3367 by adding proper support for custom comparers in unordered collection equivalency assertions. The solution uses a linear search approach for custom comparers instead of relying on Dictionary-based lookups that can fail when custom comparers have inconsistent ✅ Positive Aspects1. Problem Understanding & Solution Design
2. Code Quality
3. Test Coverage
4. API Management
|
|
Claude finished @thomhurst's task —— View job Pull Request ReviewReviewing PR #3368 that fixes issue #3367 regarding custom comparers in Review Checklist:
📋 Review SummaryThis PR implements a fix for issue #3367 by adding proper support for custom comparers in unordered collection equivalency assertions. The solution uses a linear search approach for custom comparers instead of relying on Dictionary-based lookups that can fail when custom comparers have inconsistent ✅ Positive Aspects1. Problem Understanding & Solution Design
2. Code Quality
3. Test Coverage
4. API Management
|
Fixes #3367