chore(deps): update dependency verify.nunit to 30.17.0

[thomhurst]

This PR contains the following updates:

Package	Type	Update	Change
Verify.NUnit	nuget	minor	30.16.0 -> 30.17.0

---

Release Notes

VerifyTests/Verify (Verify.NUnit)

v30.17.0

Compare Source

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot.

[claude]

Claude finished @thomhurst's task —— View job

---

PR Review: Verify.NUnit Dependency Update

I've completed my analysis of this dependency update PR. Here's my comprehensive review:

Todo List:

• Read the changed file (Directory.Packages.props)
• Analyze the dependency update scope and impact
• Check for potential compatibility issues
• Review test coverage implications
• Provide comprehensive review feedback

Review Feedback

✅ Code Quality & Best Practices

• Clean change: Single line update in centralized package management file
• Follows project patterns: Consistent with previous Renovate Bot updates (see git history)
• Version format: Proper semantic versioning (30.16.0 → 30.17.0)

⚠️ Potential Issues

1. Version Inconsistency (Minor concern):

   • Verify package: 30.16.0 (line 85)
   • Verify.NUnit: 30.17.0 (line 86) ← This PR
   • Verify.TUnit: 30.16.0 (line 90)

   This creates a mixed version state where Verify.NUnit is ahead of the base Verify package.

2. Unused Dependency (Low concern):

   • No direct references to Verify.NUnit found in any .csproj files
   • The project implements custom verification logic (see TUnit.PublicAPI/Verify.cs and TUnit.Core.SourceGenerator.Tests/Verify.cs)
   • This suggests Verify.NUnit might be unused or only used transitively

✅ Performance Considerations

• No performance impact: Minor version bump with no breaking changes expected
• Compilation impact: Minimal, as the package appears unused in source code

✅ Security Concerns

• Low risk: Minor version update from trusted package (VerifyTests)
• No malicious code: Standard dependency management pattern

✅ Test Coverage

• Custom implementation: Project uses custom VerifyTUnit classes rather than standard Verify.NUnit
• No direct usage: Tests should continue working as they don't directly depend on Verify.NUnit
• Recommendation: Run dotnet test TUnit.Core.SourceGenerator.Tests and dotnet test TUnit.PublicAPI to verify snapshot tests still pass

Recommendations

1. Consider version alignment: Update Verify package to 30.17.0 in a follow-up PR to maintain consistency
2. Verify necessity: Review if Verify.NUnit is actually needed given the custom implementations
3. Test validation: Run the project's snapshot tests to ensure compatibility

Conclusion

This is a safe, low-risk dependency update. The change follows established patterns and is unlikely to cause issues. The only minor concern is version misalignment with related packages, but this doesn't present functional risks.

Recommendation: ✅ APPROVE - Safe to merge with suggested follow-up for version consistency.

---