Conversation
337d47f to
04c55a1
Compare
There was a problem hiding this comment.
Code Review: Automated Podman CLI Options Update
This is a clean, well-structured automated PR. The changes correctly reflect the current state of the podman CLI's help output.
Summary of Changes
| File | Change |
|---|---|
AssemblyInfo.Generated.cs |
Timestamp bump (2026-02-15 → 2026-03-01) |
PodmanComposeBuildOptions |
Removed --provenance, --sbom; updated --quiet description |
PodmanComposeConfigOptions |
Removed --models |
PodmanComposeEventsOptions |
Removed --since, --until |
PodmanComposeExecOptions |
Removed --no-tty / -T |
PodmanComposePublishOptions |
Removed --app |
PodmanComposeUpOptions |
Removed --quiet-build |
PodmanImageListOptions / PodmanImagesOptions |
Updated --sort description (value list reordered) |
Assessment
Auto-generated files: All modified files are correctly tagged as auto-generated (via [ExcludeFromCodeCoverage] and the generator metadata), consistent with the project's code generation pattern. Changes should not be made manually.
Correctness: The removals of --provenance, --sbom, --models, --since, --until, --no-tty, --app, and --quiet-build are appropriate — if the CLI no longer exposes these flags, removing them from the options class is the right call.
Potential Breaking Change (informational): Users who previously set Provenance, Sbom, Models, Since, Until, NoTty, App, or QuietBuild on these options records will get a compile error after this update. This is expected and correct behaviour — the underlying CLI flags no longer exist, so the properties should not be available. A note in release notes or changelog (if applicable) would help consumers upgrading.
Sort description updates in PodmanImageListOptions and PodmanImagesOptions are cosmetic doc-string changes only; no functional impact.
Verdict
The changes look correct and the automation is working as intended. No issues to block merging.
04c55a1 to
1a59021
Compare
There was a problem hiding this comment.
Code Review: Automated Podman CLI Options Update (Re-review)
The previous review (2026-03-01) covered this PR's intent and the changes are consistent with what was assessed then. This is a re-review of the updated generation timestamp and confirming no new issues have been introduced.
Changes vs Previous Review
The only delta from the prior review is the generation timestamp in AssemblyInfo.Generated.cs moving from 2026-03-01 to 2026-03-08, indicating the generator was re-run on the updated machine state. All other changes (property removals, doc-string updates) remain identical.
Assessment
Everything from the prior review still holds:
- All files are correctly auto-generated; manual edits are intentionally avoided
- Removals of
--provenance,--sbom,--models,--since,--until,--no-tty,--app, and--quiet-buildare appropriate — the underlying CLI no longer exposes these flags --sortdescription updates inPodmanImageListOptionsandPodmanImagesOptionsare cosmetic only- Breaking change impact for consumers who used the removed properties is expected and correct (compile-time error is the right signal)
Previous concern (still informational): Consumers upgrading across this version boundary may want changelog or release note coverage for the removed options properties. This is a project-level decision, not a blocker.
Verdict
No issues. The automation is working correctly and the changes accurately reflect the current podman CLI surface area. ✓
1a59021 to
b185c50
Compare
There was a problem hiding this comment.
Code Review: Automated Podman CLI Options Update (Re-review #3)
This is a third pass over the same PR, with the generator re-run on 2026-03-15T03:13:43Z (previously 2026-03-08, before that 2026-03-01).
Delta from Previous Reviews
The only new change is the generation timestamp bump in AssemblyInfo.Generated.cs:
-[assembly: AssemblyMetadata("ModularPipelines.OptionsGenerator.GeneratedAt", "2026-02-15T03:12:09.6705108Z")]
+[assembly: AssemblyMetadata("ModularPipelines.OptionsGenerator.GeneratedAt", "2026-03-15T03:13:43.6509501Z")]
All substantive changes (property removals, doc-string updates) are identical to the prior two reviews — no new options added or removed since the 2026-03-01 snapshot.
Outstanding Items from Previous Reviews
- Breaking change note (informational): Previous reviews flagged that consumers using
Provenance,Sbom,Models,Since,Until,NoTty,App, orQuietBuildwill get compile errors after this update. This is intentional and correct behaviour, but a changelog entry remains advisable. This was flagged in both prior reviews and is still a project-level decision, not a blocker.
Verdict
No new issues introduced. The automation continues to function correctly. The repeated re-runs suggest the generator may be scheduled/triggered multiple times before the PR is merged — if this is unintentional, it may be worth reviewing the scheduling logic to avoid generating unnecessary commits on open PRs. Safe to merge.
Summary
This PR contains automatically generated updates to podman CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Verification
🤖 Generated with ModularPipelines.OptionsGenerator