Open
Conversation
Contributor
Author
|
Have to reconsider this:
|
Owner
|
In this case, the |
Contributor
Author
|
What about the original input ? is it correct what i wrote about it ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found bits of the readme confusing.
The terminology "connected component" is unnecessary in my opinion. And is also confusing because according to the current readme a connected component just needs
MonadStoreand whether theconnectfunction is used is irrelevant.I talk a bit more about the library internals, because it seemed magic to me just reading the readme. Had to dive into the code to understand.
Not sure what the purpose is of this thing https://github.com/thomashoneyman/purescript-halogen-store/blob/main/src/Halogen/Store/Connect.purs#L56 doesn't seem to be set or modified anywhere else.
Probably my edits introduced some more mistakes, can edit some more after review.