add CompactionStrategy options for Cassandra storage configuration#1156
Closed
pluradj wants to merge 1 commit intothinkaurelius:titan09from
Closed
add CompactionStrategy options for Cassandra storage configuration#1156pluradj wants to merge 1 commit intothinkaurelius:titan09from
pluradj wants to merge 1 commit intothinkaurelius:titan09from
Conversation
Contributor
Author
dalaro
added a commit
that referenced
this pull request
Dec 17, 2015
This changes the default behavior of #1156. Instead of hardcoding SizeTieredCompactionStrategy as the default and applying it in the absence of an explicit user override, this commit removes the default value for COMPACTION_STRATEGY. It also updates the three use sites to check whether the config contains COMPACTION_STRATEGY before attempting to read the option's value. Similarly, if COMPACTION_OPTIONS was not set, or if it was set to an empty map, then its use sites will not call the associated builder method, allowing the implementation to use whatever default it might have (probably empty anyway).
Member
|
I've merged this into titan11. After merging, I tweaked its default behavior in d647a69. I was concerned about how the PR hardcoded SizeTiered as the default compaction strategy in the absence of a user-specified override. My commit makes Titan behaves as it did before this PR, remaining silent on the strategy in the absence of a user-specified option, implicitly defaulting to whatever C* or the client-side driver wants to use. |
Contributor
Author
|
Makes sense. Thanks Dan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows org.apache.cassandra.db.compaction.LeveledCompactionStrategy to be chosen when the Titan tables are created.