fix: improve Linux audio device handling and waveform visualizer#1001
Open
biosed wants to merge 1 commit intothewh1teagle:mainfrom
Open
fix: improve Linux audio device handling and waveform visualizer#1001biosed wants to merge 1 commit intothewh1teagle:mainfrom
biosed wants to merge 1 commit intothewh1teagle:mainfrom
Conversation
- Use cpal device descriptions for human-friendly names instead of raw ALSA pcm_ids - Filter ALSA devices to only show "default" and "plughw:" (skip raw hw:, dmix, etc.) - Handle missing default input/output devices gracefully (no crash) - Fall back to supported_input_configs when default_input_config fails on ALSA/PipeWire - Mark ALSA "default" device as both input and output (direction is Unknown) - Replace browser getUserMedia-based waveform with backend-driven audio amplitude events (getUserMedia is unsupported in WebKitGTK on Linux) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
device.description()instead of raw ALSA pcm_ids (e.g. "MacBook Pro J314, Primary" instead ofplughw:CARD=AppleJ314,DEV=0)defaultandplughw:devices on Linux — skips rawhw:,dmix,dsnoop,surround, etc.Nonefromdefault_input_device()/default_output_device()gracefullysupported_input_configs()whendefault_input_config()returns params thatsnd_pcm_hw_paramsrejectsgetUserMedia(unsupported in WebKitGTK) with backend-drivenaudio_amplitudeevents emitted from the cpal recording streamTest plan
🤖 Generated with Claude Code