app: Switch main return type to 'int'#7544
Merged
kv2019i merged 1 commit intothesofproject:mainfrom May 4, 2023
Merged
Conversation
With Zephyr adopting a different type for 'main', adapt this application to match. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
|
Can one of the admins verify this patch?
|
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
test this please EDIT: this aligns with recent Zephyr change: |
marc-hb
approved these changes
May 1, 2023
marc-hb
requested review from
aborisovich,
andyross,
kv2019i,
lyakh,
paulstelian97 and
softwarecki
ranj063
reviewed
May 1, 2023
ranj063
approved these changes
May 1, 2023
paulstelian97
approved these changes
May 2, 2023
stephanosio
approved these changes
May 2, 2023
dbaluta
approved these changes
May 2, 2023
Collaborator
|
Ready to go, pending CI results for Intel quickbuild -> @wszypelt |
softwarecki
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Zephyr adopting a different type for 'main', adapt this application to match.
This is required when building without the
-ffreestandingcompiler flag as the C standard for "hosted" applications requires one of a small set of specific signatures for themainfunction.