Fixed exercises with a maximum number of transaction requirement#108
Open
l4n0r wants to merge 1 commit intotheredguild:masterfrom
Open
Fixed exercises with a maximum number of transaction requirement#108l4n0r wants to merge 1 commit intotheredguild:masterfrom
l4n0r wants to merge 1 commit intotheredguild:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some challenges enforce a maximum number of transactions, which is tracked using Foundry's
vm.getNonce.While the current approach uses
vm.startPrankto simulate player transactions, this method only setsmsg.senderandtx.origin— it does not increment the sender's nonce for each transaction (except for contract creations). As a result, nonce-based checks are not effective in counting regular transactions.Foundry provides
vm.startBroadcast, which is specifically designed to simulate real transactions that do increment the nonce. This pull request replacesvm.startPrankwithvm.startBroadcast(only for the selected challenges) to more accurately enforce transaction count limits.