Skip to content

Conversation

@MParvin
Copy link
Contributor

@MParvin MParvin commented Feb 14, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation content changes

Other information

I translate Falco to Farsi (Persian language)

@phacks
Copy link
Contributor

phacks commented Mar 1, 2020

Thank you so very very much, this is awesome! Sorry for the delay, I'm currently moving out to a new place which does not leave me much time for open source. Hopefully it'll be better soon!

I tried my best to review this PR but as I don’t speak Farsi, I could only do that via Google Translate. You will find here a side-by-side comparison of my english translation and the Google Translated english version of your Farsi translation in this Google Docs. From the looks of it it seems OK so I can merge it when you're ready, but if you want to proofread it please do so!

Also, I didn’t test the Falco docs or application on a RTL language. Is it working properly? If not, would you like to open issues for any improvement you’d like to see?

Thanks again!

@phacks phacks merged commit 32ab12e into theodo:master Mar 9, 2020
@phacks
Copy link
Contributor

phacks commented Mar 18, 2020

@all-contributors please add @MParvin for translation!

@allcontributors
Copy link
Contributor

@phacks

I've put up a pull request to add @MParvin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants