Fixing CSS Issues in sabnzbd-base.css#680
Merged
GilbN merged 1 commit intothemepark-dev:developfrom Apr 21, 2025
zdhoward:develop
Merged
Fixing CSS Issues in sabnzbd-base.css#680GilbN merged 1 commit intothemepark-dev:developfrom zdhoward:develop
GilbN merged 1 commit intothemepark-dev:developfrom
zdhoward:develop
Conversation
Collaborator
|
Thanks for the fix! Looks great! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read the contributing guideline and understand that I have made the correct modifications
PR's are done against the develop branch.
Bug fixes
Before images:











After images:












Description:
I went through the sabnzbd-base.css file and did my best to use what already existed to fix up css issues all over.
Tested mainly using hotline.css
This is also my first contribution to this project so if anything here isn't done correctly, just let me know and I'll be happy to fix it.
Benefits of this PR and context:
Fixes existing base css issues for the sabnzbd app
How Has This Been Tested?
I am using brave browser and did most of my work in the inspector, under Source with the sabnzbd-base.css file.
Then I put it in my theme-park docker container to let my app grab it using docker mods.
Testing was just looking through each page and seeing if any elements weren't using values from the theme.
Should only effect other themes on sabnzbd, but as long as the colors are set up in the same way as hotline.css then it should work well. Spot checked a couple others like hotpink and plex and it is all looking good.
Source / References: