Cannot remove directory when waste basket is a separate btrfs subvolume

[jtrees]

Steps to Reproduce

1. Create a btrfs subvolume to be used as the waste basket
2. Configure rmw to use the subvolume as a waste basket
3. Try to remove any directory with rmw

Expected Outcome

The directory is moved to the wastebasket with all contained files.

Actual Outcome

$ rmw ~/any-dir/
ioctl: Is a directory in do_btrfs_clone

[andy5995]

Thanks for the report @jtrees , I'm now working on it in #498

[andy5995]

@jtrees I merged a probable fix to the master branch. Are you able to test it? I think the test I added is adequate but I usually wind up missing something. ;)

[jtrees]

@andy5995 Thanks! I gave it a whirl but unfortunately it doesn't work yet:

$ mkdir ~/foo; rmw ~/foo
  :error: /home/josh/foo -> /home/josh/.local/share/Trash/files/foo_232300-251025
rename: Invalid cross-device link

This is my subvolume layout:

$ sudo btrfs subvolume list /
ID 257 gen 38650 top level 5 path home
ID 431 gen 38634 top level 257 path home/josh/.local/share/Trash

[andy5995]

Thank you. I'll have a look soon.