Skip to content

Don't show the tracking notice, when opt-in or opt-out has already be… #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thefrosty merged 1 commit into from
Aug 9, 2022
Merged

Don't show the tracking notice, when opt-in or opt-out has already be… #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/WpAdmin/Tracking.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,21 @@ protected function checkForOptOut(): void
}

/**
* Display the admin notice to users that have not opted-in or out
* Display the admin notice to users that have not opted-in or out.
* Don't show this notice when _not_ on the Custom Login settings page.
* Don't show this notice when the hide tracking notice has been "saved".
*/
protected function adminNotice(): void
{
if (!isSettingsPage($this->getPlugin())) {
return;
}

// Check the notice setting _after_ settings page check..
if (!empty(get_option(self::OPTION_HIDE_TRACKING_NOTICE))) {
return;
}

printf(
$this->getView(ServiceProvider::WP_UTILITIES_VIEW)->retrieve(
'notices/admin-notice.php',
Expand Down