Fixes #19478 - migrate to webpack2 #4514

matanwerbner · 2017-05-09T08:58:17Z

As webpack 1 is being deprecated, we better migrate to 2 to have full support and updates.

matanwerbner · 2017-05-09T10:15:51Z

storybook works fine as well.

ohadlevy · 2017-05-09T10:18:23Z

package.json

    "jstz": "~1.0.7",
    "lodash": "~4.15.0",
    "multiselect": "~0.9.12",
+    "fbjs": "0.8.12",


is it required by webpack2 now?

seems so.
http://stackoverflow.com/questions/43751744/cant-resolve-fbjs-lib-memoizestringonly?noredirect=1&lq=1

ohadlevy · 2017-05-09T12:00:41Z

[test foreman]

ohadlevy · 2017-05-09T12:00:48Z

[test katello]

ohadlevy · 2017-05-09T12:03:35Z

package.json

    "style-loader": "^0.13.1",
    "url-loader": "^0.5.7",
-    "webpack": "^1.9.11",
+    "webpack": "^2.5.1",


when testing it i got:

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=4.3.0 < 5.0.0 || >= 5.10". error Found incompatible module

any idea what are the new minimum requirements? I assume this is going to effect our build infra too.
/cc @tbrisker

this is probably a local issue that i had node v5.0.0 by mistake.

@matanwerbner 2.6.1 is already the latest, can you revisit all the dependencies mentioned here?

ohadlevy · 2017-05-09T14:10:50Z

@matanwerbner I've noticed its slower, do you think wepack v2 is ready for "production"?

matanwerbner · 2017-05-09T15:25:47Z

@ohadlevy it is definatley pro

matanwerbner · 2017-05-09T15:27:25Z

Definatley prod ready although i seen many user experiencing slower build times, and reverting to v1 (which is officialy deprecated).
We can probably hold off on this for a while.

ohadlevy · 2017-05-10T09:20:39Z

package.json

    "react-addons-test-utils": "^15.3.1",
    "redux-mock-store": "^1.2.2",
    "sass-loader": "~4.1.1",
    "stats-webpack-plugin": "^0.2.1",


need to bump version

ohadlevy · 2017-05-10T09:22:36Z

also need to change the - webpack.optimize.OccurenceOrderPlugin(), to webpack.optimize.OccurrenceOrderPlugin
but it might not be required at all anymore - see webpack/webpack#1964 and https://gist.github.com/sokra/27b24881210b56bbaff7#occurrence-order

ohadlevy · 2017-06-01T11:59:15Z

@matanwerbner I've been using it over a week on my instance without a significant impact, I'm fine with merging this.

matanwerbner · 2017-06-04T08:01:46Z

@ohadlevy i have rebased, feel free to merge :)

matanwerbner · 2017-06-13T10:34:38Z

@ohadlevy tests are good

ohadlevy · 2017-06-13T14:55:42Z

@matanwerbner seems to work, I am however seeing the following:

WARNING in webpack: Using NoErrorsPlugin is deprecated.
Use NoEmitOnErrorsPlugin instead.

ohadlevy · 2017-06-19T09:11:38Z

setting as WoC as I'm still getting

WARNING in webpack: Using NoErrorsPlugin is deprecated.
Use NoEmitOnErrorsPlugin instead.

ohadlevy · 2017-06-19T19:09:53Z

should we wait? https://twitter.com/TheLarkInn/status/876853489049010176

matanwerbner · 2017-06-19T19:30:20Z

guess so... 😆

matanwerbner · 2017-06-20T11:22:23Z

@ohadlevy it's v3 now, no improvement in the file size, however bundle is structured a bit differently, in a way that is supposed to improve performance.
this is freshly rebased.

ohadlevy · 2017-06-20T11:28:41Z

nice! can you just address:

Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead.

matanwerbner · 2017-06-20T11:35:06Z

we need to watch this space:
webpack-contrib/extract-text-webpack-plugin#543

ohadlevy · 2017-06-20T11:36:13Z

I also see

warning "[email protected]" has incorrect peer dependency "webpack@^2.2.0".

should we bump extract-text version?

matanwerbner · 2017-06-20T11:39:00Z

@ohadlevy we are at latest, nowhere to bump.
extract-text-plugin does not yet support webpack v3...hence the PR i've attached.

ohadlevy · 2017-06-20T12:02:22Z

also..

warning "[email protected]" has incorrect peer dependency "webpack@^2.2.0".
warning "[email protected]" has incorrect peer dependency "webpack@^2 || ^2.2.0-rc.0 || ^2.1.0-beta || ^1.12.6".
warning "[email protected]" has incorrect peer dependency "webpack@^1.0||^2.1.0-beta||^2.2.0-rc".
warning "[email protected]" has incorrect peer dependency "webpack@>=1.3.0 <3".

matanwerbner · 2017-06-22T07:52:35Z

@ohadlevy should we go back to v2, and wait for 3 to stabilize?

ohadlevy · 2017-06-22T08:05:22Z

On Thu, Jun 22, 2017 at 10:52 AM, matanwerbner ***@***.***> wrote: @ohadlevy <https://github.com/ohadlevy> should we go back to v2, and wait for 3 to stabilize?

I'm running v3 in prod since your PR with no issues - is it simply a warning that we can ignore or more than that?

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4514 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABOx3VkiZ8eaQcyfsgb606XVmrfj8wqks5sGh1DgaJpZM4NVA0B> .

matanwerbner · 2017-06-22T08:33:21Z

Hard to say, it seems like no braking changes have occured, i however would feel more comfortable to wait with it.
also, it doesn't bring any significant improvements to the table... your call :)

ohadlevy · 2017-06-26T05:43:47Z

thanks @matanwerbner

ohadlevy · 2017-06-26T05:44:26Z

packaging pr at theforeman/foreman-packaging#1693

This was needed as a workaround[1] that's no longer needed. [1]: theforeman#4514 (comment)

This was needed as a workaround[1] that's no longer needed. [1]: #4514 (comment)

This was needed as a workaround[1] that's no longer needed. [1]: theforeman#4514 (comment)

theforeman-bot added Needs testing Not yet reviewed labels May 9, 2017

ohadlevy reviewed May 9, 2017

View reviewed changes

matanwerbner closed this May 9, 2017

matanwerbner reopened this May 9, 2017

ohadlevy reviewed May 10, 2017

View reviewed changes

dLobatog added Waiting on contributor and removed Needs testing Not yet reviewed labels May 29, 2017

matanwerbner force-pushed the fix_19478_webpack_2 branch from eb7c1ef to 7dd7ad7 Compare June 4, 2017 08:01

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Jun 4, 2017

matanwerbner force-pushed the fix_19478_webpack_2 branch from 7dd7ad7 to ba0ddd6 Compare June 13, 2017 08:23

ohadlevy added Waiting on contributor and removed Needs re-review Needs testing labels Jun 19, 2017

matanwerbner force-pushed the fix_19478_webpack_2 branch from ba0ddd6 to f67e280 Compare June 19, 2017 10:21

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Jun 19, 2017

Fixes #19478 - migrate to webpack2

66df468

matanwerbner force-pushed the fix_19478_webpack_2 branch from f67e280 to 66df468 Compare June 20, 2017 11:16

ohadlevy merged commit 114ea49 into theforeman:develop Jun 26, 2017

ekohl added a commit to ekohl/foreman that referenced this pull request Nov 27, 2017

Fixes #21774 - Drop fbjs requirement

a1d2dbc

This was needed as a workaround[1] that's no longer needed. [1]: theforeman#4514 (comment)

ekohl mentioned this pull request Nov 27, 2017

Fixes #21774 - Drop fbjs requirement #5029

Merged

tbrisker pushed a commit that referenced this pull request Nov 27, 2017

Fixes #21774 - Drop fbjs requirement

cb3d716

This was needed as a workaround[1] that's no longer needed. [1]: #4514 (comment)

mmack pushed a commit to mmack/foreman that referenced this pull request Dec 13, 2017

Fixes #21774 - Drop fbjs requirement

f8ec6d2

This was needed as a workaround[1] that's no longer needed. [1]: theforeman#4514 (comment)

Fixes #19478 - migrate to webpack2 #4514

Fixes #19478 - migrate to webpack2 #4514

Uh oh!

Conversation

matanwerbner commented May 9, 2017

Uh oh!

matanwerbner commented May 9, 2017

Uh oh!

ohadlevy May 9, 2017

Choose a reason for hiding this comment

Uh oh!

matanwerbner May 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ohadlevy commented May 9, 2017

Uh oh!

ohadlevy commented May 9, 2017

Uh oh!

ohadlevy May 9, 2017

Choose a reason for hiding this comment

Uh oh!

ohadlevy May 9, 2017

Choose a reason for hiding this comment

Uh oh!

ohadlevy Jun 7, 2017

Choose a reason for hiding this comment

Uh oh!

ohadlevy commented May 9, 2017

Uh oh!

matanwerbner commented May 9, 2017

Uh oh!

matanwerbner commented May 9, 2017

Uh oh!

ohadlevy May 10, 2017

Choose a reason for hiding this comment

Uh oh!

ohadlevy commented May 10, 2017

Uh oh!

ohadlevy commented Jun 1, 2017

Uh oh!

matanwerbner commented Jun 4, 2017

Uh oh!

matanwerbner commented Jun 13, 2017

Uh oh!

ohadlevy commented Jun 13, 2017

Uh oh!

ohadlevy commented Jun 19, 2017

Uh oh!

ohadlevy commented Jun 19, 2017

Uh oh!

matanwerbner commented Jun 19, 2017

Uh oh!

matanwerbner commented Jun 20, 2017

Uh oh!

ohadlevy commented Jun 20, 2017

Uh oh!

matanwerbner commented Jun 20, 2017

Uh oh!

ohadlevy commented Jun 20, 2017

Uh oh!

matanwerbner commented Jun 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ohadlevy commented Jun 20, 2017

Uh oh!

matanwerbner commented Jun 22, 2017

Uh oh!

ohadlevy commented Jun 22, 2017 via email

Uh oh!

matanwerbner commented Jun 22, 2017

Uh oh!

ohadlevy commented Jun 26, 2017

Uh oh!

ohadlevy commented Jun 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

matanwerbner May 9, 2017 •

edited

Loading

matanwerbner commented Jun 20, 2017 •

edited

Loading