Skip to content

fix: handle npm install errors #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2025
Merged

fix: handle npm install errors #312

merged 2 commits into from
Nov 18, 2025

Conversation

@zachfedor
Copy link
Contributor

@zachfedor zachfedor commented Nov 18, 2025

  • Check if npm exists before running install
  • Handle error case if command fails at OS level (e.g. permission issue, path incorrect, etc)
  • Handle error case if command fails during install (e.g. network issue, bad dependency, etc)
  • Move git commands later in process

Fixes #307

@zachfedor zachfedor requested a review from willemneal November 18, 2025 16:01
@zachfedor zachfedor merged commit c8d5fdc into main Nov 18, 2025
2 of 3 checks passed
@zachfedor zachfedor deleted the fix/init-check-npm branch November 18, 2025 19:12
@stellar-scaffold stellar-scaffold bot mentioned this pull request Nov 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willemneal willemneal willemneal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[stellar-scaffold-cli] Non-descriptive error if npm is not installed

3 participants

@zachfedor @willemneal