This repository was archived by the owner on Feb 19, 2021. It is now read-only.
Make consumer create target directories #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastianPoe
force-pushed
the
bugfix-651
branch
6 times, most recently
from
f0ce21b to
8182593
Compare
MasterofJOKers
suggested changes
May 17, 2020
Turns out, that override_settings is actually keeping the override for following test cases (even if you disable them). This leads to an overriden MEDIA_ROOT that no longer exists. test_file_deletion does not do any file operations, but find_renamed_document was assuming the MEDIA_ROOT is actually exist.
…ttings work as it should. Quote from https://docs.djangoproject.com/en/3.0/topics/testing/tools/#django.test.override_settings: Finally, avoid aliasing your settings as module-level constants as override_settings() won’t work on such values since they are only evaluated the first time the module is imported.
existing) class variable
Contributor
|
@MasterofJOKers will you kindly spend 5 minutes? |
Contributor
Author
|
@MasterofJOKers @pitkley @danielquinn, could anyone of you please review this PR? It is open for several month now and I would like to close this issue. This is time-critical, as this addresses a bug currently found on master.r |
pitkley
approved these changes
Sep 15, 2020
MasterofJOKers
approved these changes
Jan 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #651