This repository was archived by the owner on Mar 18, 2025. It is now read-only.
compile and run conductor as WASM (for CloudFlare Worker) #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotansimha
changed the title
Contributor
|
🤯🚀 |
|
🐋 This PR was built and pushed to the following Docker images: Docker Bake metadata{
"conductor": {
"containerimage.config.digest": "sha256:1623f20618b9a20217ad543fe688dcda3829e5661f96250b0f68721c6c7e10d8",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"digest": "sha256:054c99f2a11a63680f062d7d7e2c78e985033fc616c05adb5db09231d7a407d0",
"size": 901,
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
"containerimage.digest": "sha256:054c99f2a11a63680f062d7d7e2c78e985033fc616c05adb5db09231d7a407d0",
"image.name": "ghcr.io/the-guild-org/conductor-t2/conductor:2583ec5ff7069f370ce7c3b87564f90532c9c0e3"
}
} |
Comment on lines
+15
to
+18
| let conductor_config_str = env.var("CONDUCTOR_CONFIG").map(|v| v.to_string()); | ||
|
|
||
| match conductor_config_str { | ||
| Ok(conductor_config_str) => match from_yaml(&conductor_config_str) { |
Contributor
There was a problem hiding this comment.
This is gonna a bit inefficient to load and parse the config file on every request,
what can we do to maintain this sort of state in a cloudflare function where the function is just stateless? 🤔
| let gw = ConductorGateway::lazy(conductor_config); | ||
|
|
||
| if let Some(route_data) = gw.match_route(&req.url().unwrap()) { | ||
| console_log!("Route found: {:?}", route_data); |
Contributor
There was a problem hiding this comment.
I'm not sure if console_log! macro is handling logging efficiently in production,
It comes from worker_sys by cloudflare workers, and the inline docs are:
When debugging your Worker via wrangler dev, wrangler tail, or from the Workers Dashboard,
anything passed to this macro will be printed to the terminal or written to the console.
Comment on lines
+32
to
+36
|
|
||
| let body = req.bytes().await.unwrap().into(); | ||
| let uri = req.url().unwrap().to_string(); | ||
| let query_string = req.url().unwrap().query().unwrap_or_default().to_string(); | ||
| let method = Method::from_str(req.method().as_ref()).unwrap(); |
Contributor
There was a problem hiding this comment.
we can provide helpful error messages later on instead of .expect()
YassinEldeeb
pushed a commit
that referenced
this pull request
Nov 19, 2023
…a HTTP server, and also CF Worker (wasm) runtime (#127) * restructure ok separated config now wip wip wip ok ok ok it's working again ok getting there ok bring back plugins fix graphiql fix graphiql again fix tracing ok ok ok fix clippy, fmt, over-http and ci fix benches fix deps fix docker image fix * compile and run conductor as WASM (for CloudFlare Worker) (#134)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #98
tokiodependencyreqwest/ other client