grpc: fix memory consumption problems #8553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GiedriusS
commented
Nov 6, 2025
GiedriusS
commented
- Implement io.WriterTo on the snappy decompressor which allows not overallocating memory for decompression
- Deploy a hack thanos-community/grpc-go@b902040 because the io.WriterTo assertion doesn't work with limited recv size at the moment
- Disable pooling on unmarshaling and allocate slices that have the exactly needed size. This allows to not overprovision memory because the default memory pool in gRPC has quite coarsely grained buckets.
- Remove copying of chunks from *AggrChunk because we don't do any pooling on unmarshaling either way. This saves a bit of memory.
- Implement io.WriterTo on the snappy decompressor which allows not overallocating memory for decompression - Deploy a hack thanos-community/grpc-go@b902040 because the io.WriterTo assertion doesn't work with limited recv size at the moment - Disable pooling on unmarshaling and allocate slices that have the exactly needed size. This allows to not overprovision memory because the default memory pool in gRPC has quite coarsely grained buckets. - Remove copying of chunks from *AggrChunk because we don't do any pooling on unmarshaling either way. This saves a bit of memory. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
fixmemoryconsumption
branch
from
414b1eb to
569d4e2
Compare
MichaHoffmann
approved these changes
Nov 12, 2025
|
Genuinely curious about this, did you by any chance profile memory usage before and after this change ? |
Member
Author
|
Sure, I ran the benchmark that is included in this PR. Only allocs/s is still higher compared to v0.39.2. This might be because the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.