feat: add skipPatterns option
#75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hello @azu |
azu
requested changes
Jan 17, 2019
Member
azu
left a comment
azu
left a comment
There was a problem hiding this comment.
Thanks for Pull Request.
I recommend that you use @textlint/regexp-string-matcher in this usecase.
Or, introduce separated skipWords and skipRegExp option.
Author
|
@azu I change it to |
Author
|
Thank you! Could you bump up the version number and upload to npm? |
Member
|
Yes. I'll update devDeps before publishing. |
Member
Author
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since some jargon cannot be recognized by ginger, I added this options to skip errors.
This feature has already been implemented
textlint-rule-spellchecker.For me, it is enough to add this property from
textlint-rule-spellchecker, however someone may want the other features. Since I have no time to do it, I stop to add the other features.Anyway, I guess this request make your project to be better.
Thank you!