chore(main): [bot] release t8s-cluster:9.4.0#1680
Conversation
teutonet-bot
requested review from
a team,
cwrau,
marvinWolff and
tasches
as code owners
|
Caution Review failedThe pull request is closed. WalkthroughBump t8s-cluster chart from 9.3.1 to 9.4.0 in manifest and Chart.yaml, add a new 9.4.0 changelog entry, and update README/schema and Chart.yaml annotations; no code/runtime logic changes. Changes
Sequence Diagram(s)(omitted — changes are metadata and docs-only; no control-flow changes to diagram) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
from
30d67ec to
9fce503
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/t8s-cluster/Chart.yaml (1)
18-19: Nit: update the sources tag to v9.3.2.Keep the first sources entry pointing to the new release tag once it's created to aid traceability.
Apply this diff after the tag exists:
- - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.3.1/charts/t8s-cluster + - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.3.2/charts/t8s-cluster
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/release-please/manifest.json(1 hunks)charts/t8s-cluster/CHANGELOG.md(1 hunks)charts/t8s-cluster/Chart.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-24T09:41:28.072Z
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Applied to files:
charts/t8s-cluster/Chart.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: update metadata file for release
- GitHub Check: lint helm chart (t8s-cluster)
🔇 Additional comments (3)
charts/t8s-cluster/Chart.yaml (1)
21-21: Version bump looks good and consistent.Chart version 9.3.2 aligns with the PR intent and CHANGELOG entry.
.github/release-please/manifest.json (1)
1-1: Manifest entry matches the chart bump.t8s-cluster set to 9.3.2; no issues spotted.
Confirm Release Please only staged a release for t8s-cluster in this PR (no unintended package bumps).
charts/t8s-cluster/CHANGELOG.md (1)
3-8: Changelog entry is correct.Compare link, tag, and date for 9.3.2 look consistent.
teutonet-bot
changed the title
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
2 times, most recently
from
30a5a2a to
055a2c0
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (6)
charts/t8s-cluster/README.md (6)
546-549: Clarify Dynamic Resource Allocation reference with a docs link.
Add a link to Kubernetes docs to reduce ambiguity.Apply:
- | - [claims](#controlPlane_resources_claims ) | No | array | No | - | Claims lists the names of resources, defined in spec.resourceClaims, that are used by this container.<br /><br />This field depends on the DynamicResourceAllocation feature gate.<br /><br />This field is immutable. It can only be set for containers. | + | - [claims](#controlPlane_resources_claims ) | No | array | No | - | Claims lists the names of resources, defined in spec.resourceClaims, that are used by this container.<br /><br />This field depends on the DynamicResourceAllocation feature gate (https://kubernetes.io/docs/concepts/scheduling-eviction/dynamic-resource-allocation/).<br /><br />This field is immutable. It can only be set for containers. |If this file is generated, please add the link in the schema description so it persists.
558-561: Inline note: link the feature gate doc here as well.
Keep consistency with the table entry above.-This field depends on the DynamicResourceAllocation feature gate. +This field depends on the DynamicResourceAllocation feature gate (https://kubernetes.io/docs/concepts/scheduling-eviction/dynamic-resource-allocation/).
727-732: Replicas semantics: add a one‑liner explaining fixed vs autoscaling.
Currently the type is clear, but the behavior isn’t explicit.- | + [replicas](#nodePools_additionalProperties_replicas ) | No | Combination | No | - | - | + | + [replicas](#nodePools_additionalProperties_replicas ) | No | Combination | No | - | When an integer is provided, the pool is fixed-size; when an object with min/max is provided, autoscaling is enabled. |If autogenerated, embed this text in the schema so regen preserves it.
735-744: Document constraint: min must be <= max.
Helm schema can’t enforce cross-field checks; add a doc note to prevent misconfig.##### <a name="nodePools_additionalProperties_replicas_oneOf_i1"></a>6.1.1.2. Property `t8s cluster configuration > nodePools > additionalProperties > replicas > oneOf > item 1` | | | | ------------------------- | -------------------------------------------------------------- | | **Type** | `object` | | **Additional properties** |  | +Note: min must be less than or equal to max.
755-786: Confirm intended lower bound for autoscaling min/max.
Static replicas allow 0, but autoscaling min/max both require ≥1. If scale-to-zero should be supported for autoscaled pools, consider allowing min ≥0.If scale-to-zero is desired:
- | **Minimum** | ≥ 1 | + | **Minimum** | ≥ 0 |Otherwise, consider adding a brief rationale (e.g., “Autoscaled node pools must keep at least one node”).
433-434: remoteGroupID: clarify scope and example.
Specify it’s an OpenStack security group ID (UUID) and add a short example for users.- | + [remoteGroupID](#controlPlane_additionalSecurityGroupRules_additionalProperties_remoteGroupID ) | No | string | No | - | The ID of the security group to allow traffic from | + | + [remoteGroupID](#controlPlane_additionalSecurityGroupRules_additionalProperties_remoteGroupID ) | No | string | No | - | The OpenStack security group ID (UUID) to allow traffic from | @@ -**Description:** The ID of the security group to allow traffic from +**Description:** The OpenStack security group ID (UUID) to allow traffic from. Use `allowedCIDRs` for IP/CIDR-based rules. + +Example: +```yaml +controlPlane: + additionalSecurityGroupRules: + someRule: + protocol: tcp + port: 6443 + remoteGroupID: "8c5f6f4a-2d1e-4c1b-bc7a-3f4b3c9c6d10" +```Also applies to: 498-505
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
charts/t8s-cluster/Chart.yaml(1 hunks)charts/t8s-cluster/README.md(6 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- charts/t8s-cluster/Chart.yaml
🔇 Additional comments (1)
charts/t8s-cluster/README.md (1)
4-4: Version badge bump looks good.
Matches the 9.4.0 release intent.
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
3 times, most recently
from
5d47f85 to
90e5b1d
Compare
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
from
4637355 to
01f77c0
Compare
teutonet-bot
deleted the
release-please--branches--main--components--t8s-cluster
branch
|
🤖 Created releases: 🌻 |
2 participants
🤖 I have created a release beep boop
9.4.0 (2025-09-26)
Features
Miscellaneous Chores
This PR was generated with Release Please. See documentation.
Summary by CodeRabbit
New Features
Documentation
Chores