Skip to content

Conversation

@baflQA
Copy link
Contributor

@baflQA baflQA commented Dec 30, 2025

Fixes #.

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

Description

This pull request improves the CI workflow by updating the early access JDK version in the test matrix.

Changes:

  • Replaced JDK 24 with JDK 25 in .github/workflows/matrix.js.
  • Updated CHANGES.txt to reflect the workflow improvement.
  • Verified the updated matrix generation by running node .github/workflows/matrix.js locally.
  • Applied automatic styling via ./gradlew autostyleApply.

Summary by CodeRabbit

  • Chores

    • Updated CI test matrix to include Java 25 (JDK 25) and Java 26 early-access.
  • Bug Fixes

    • Fixed data provider parameter refresh on retries when test-retry caching is disabled.
    • Resolved false-positive order assertion when actual collection is a subset with equal size.
    • Ensured suite XML serialization preserves newly added properties (e.g., thread pool sharing).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

📝 Walkthrough

Walkthrough

Updated the GitHub Actions test matrix to add JDK 25 and move the EA default to JDK 26 by changing the eaJava constant; added a matrix row to ensure at least one job uses Java 25 and updated the changelog.

Changes

Cohort / File(s) Summary
CI/CD Configuration
.github/workflows/matrix.js
Changed eaJava constant from '24' to '26'; added '25' to the java_version list; added matrix-row generation to ensure at least one job runs with Java 25.
Changelog
CHANGES.txt
Added entry documenting the GitHub Actions test matrix update to include JDK 25 and JDK 26 EA.

Sequence Diagram(s)

(None — change is a small configuration update and does not introduce new multi-component control flow.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • krmahadevan
  • juherr

Poem

🐰 I hopped the matrix, two-five in tow,
Pipelines twitch, a brighter build-glow.
EA leaps onward, twenty-six now bold,
Tests line up neatly, stories retold. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Improve/test workflow jdk25' is vague and uses non-descriptive terms that don't clearly convey the specific change being made. Use a more specific title like 'Update GitHub Actions test matrix to include JDK 25' or 'Replace JDK 24 with JDK 25 in CI workflow' to clearly describe the primary change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/matrix.js (1)

23-23: JDK 25 is available and stable — change is valid.

JDK 25 is confirmed as GA (General Availability) on jdk.java.net and ready for production use. The constant update and Oracle distribution logic at lines 72, 74, and 116 are correct.

Minor note: The variable name eaJava is now technically misleading since JDK 25 is GA rather than Early Access. Consider renaming to latestJava or updating the comment at line 89 for clarity, though this does not affect functionality.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61068a1 and bc4d290.

📒 Files selected for processing (2)
  • .github/workflows/matrix.js
  • CHANGES.txt
🔇 Additional comments (1)
CHANGES.txt (1)

2-2: LGTM! Changelog entry is clear and follows the standard format.

The documentation accurately reflects the workflow update to JDK 25.

@baflQA baflQA requested a review from juherr December 30, 2025 18:16
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGES.txt (1)

2-2: Changelog entry accurately documents the workflow update.

The entry appropriately documents the GitHub Actions test matrix improvements by mentioning the addition of JDK 25 and JDK 26 EA. For additional clarity, consider noting that JDK 24 was replaced (e.g., "...matrix to replace JDK 24 with JDK 25 and update EA to JDK 26"), but the current phrasing is acceptable.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a34439 and 1ac513b.

📒 Files selected for processing (2)
  • .github/workflows/matrix.js
  • CHANGES.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/matrix.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: 17, corretto, same hashcode, windows, America/New_York, tr_TR, stress JIT
  • GitHub Check: 21, liberica, ubuntu, Pacific/Chatham, fr_FR, stress JIT
  • GitHub Check: 26, oracle, macos, America/New_York, de_DE
  • GitHub Check: 11, zulu, windows, UTC, tr_TR, stress JIT
  • GitHub Check: 25, temurin, macos, UTC, tr_TR
  • GitHub Check: 11, temurin, windows, America/New_York, ru_RU
  • GitHub Check: 11, temurin, macos, UTC, tr_TR

@baflQA
Copy link
Contributor Author

baflQA commented Dec 30, 2025

Let's merge it then.

@baflQA baflQA changed the title Improve/test workflow jdk25 v2 Improve/test workflow jdk25 Dec 30, 2025
@krmahadevan
Copy link
Member

@baflQA - There are merge conflicts on this PR

@baflQA
Copy link
Contributor Author

baflQA commented Dec 31, 2025

Hey - I don't see any. Especially since I am not able to merge by myself. The git says that I'm up to date with master when I try to do the rebase/merge master.

@krmahadevan
Copy link
Member

I see that when I choose Rebase and merge as the merge strategy.

image

But when I switch to squash and merge it goes through. So we are good here.

@krmahadevan krmahadevan merged commit bad4cb5 into testng-team:master Dec 31, 2025
9 of 10 checks passed
@baflQA baflQA deleted the improve/test-workflow-jdk25-v2 branch December 31, 2025 10:20
krmahadevan pushed a commit to krmahadevan/testng that referenced this pull request Jan 21, 2026
* Improve test.yml workflow: replace JDK 24 with JDK 25 in matrix
* Update test matrix: add JDK 25 and set eaJava to 26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants