-
Notifications
You must be signed in to change notification settings - Fork 1k
Improve/test workflow jdk25 #3253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve/test workflow jdk25 #3253
Conversation
📝 WalkthroughWalkthroughUpdated the GitHub Actions test matrix to add JDK 25 and move the EA default to JDK 26 by changing the Changes
Sequence Diagram(s)(None — change is a small configuration update and does not introduce new multi-component control flow.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/matrix.js (1)
23-23: JDK 25 is available and stable — change is valid.JDK 25 is confirmed as GA (General Availability) on jdk.java.net and ready for production use. The constant update and Oracle distribution logic at lines 72, 74, and 116 are correct.
Minor note: The variable name
eaJavais now technically misleading since JDK 25 is GA rather than Early Access. Consider renaming tolatestJavaor updating the comment at line 89 for clarity, though this does not affect functionality.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/matrix.jsCHANGES.txt
🔇 Additional comments (1)
CHANGES.txt (1)
2-2: LGTM! Changelog entry is clear and follows the standard format.The documentation accurately reflects the workflow update to JDK 25.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGES.txt (1)
2-2: Changelog entry accurately documents the workflow update.The entry appropriately documents the GitHub Actions test matrix improvements by mentioning the addition of JDK 25 and JDK 26 EA. For additional clarity, consider noting that JDK 24 was replaced (e.g., "...matrix to replace JDK 24 with JDK 25 and update EA to JDK 26"), but the current phrasing is acceptable.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/matrix.jsCHANGES.txt
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/matrix.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: 17, corretto, same hashcode, windows, America/New_York, tr_TR, stress JIT
- GitHub Check: 21, liberica, ubuntu, Pacific/Chatham, fr_FR, stress JIT
- GitHub Check: 26, oracle, macos, America/New_York, de_DE
- GitHub Check: 11, zulu, windows, UTC, tr_TR, stress JIT
- GitHub Check: 25, temurin, macos, UTC, tr_TR
- GitHub Check: 11, temurin, windows, America/New_York, ru_RU
- GitHub Check: 11, temurin, macos, UTC, tr_TR
|
Let's merge it then. |
|
@baflQA - There are merge conflicts on this PR |
|
Hey - I don't see any. Especially since I am not able to merge by myself. The git says that I'm up to date with master when I try to do the rebase/merge master. |
* Improve test.yml workflow: replace JDK 24 with JDK 25 in matrix * Update test matrix: add JDK 25 and set eaJava to 26

Fixes #.
Did you remember to?
CHANGES.txt./gradlew autostyleApplyDescription
This pull request improves the CI workflow by updating the early access JDK version in the test matrix.
Changes:
.github/workflows/matrix.js.CHANGES.txtto reflect the workflow improvement.node .github/workflows/matrix.jslocally../gradlew autostyleApply.Summary by CodeRabbit
Chores
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.