Bobshie beforeconfig skip #2881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Shi <[email protected]>
Signed-off-by: Bob Shi <[email protected]>
Signed-off-by: Bob Shi <[email protected]>
krmahadevan
reviewed
Mar 11, 2023
testng-core/src/test/java/test/listeners/issue2880/IssueTest.java
Outdated
Show resolved
Hide resolved
krmahadevan
reviewed
Mar 11, 2023
krmahadevan
requested changes
Mar 11, 2023
Member
krmahadevan
left a comment
krmahadevan
left a comment
There was a problem hiding this comment.
Have shared some comments
juherr
reviewed
Mar 12, 2023
Member
juherr
left a comment
juherr
left a comment
There was a problem hiding this comment.
Lgtm once approved by @krmahadevan
|
|
Signed-off-by: Bob Shi <[email protected]>
krmahadevan
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2880 .
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.