Skip to content

fix(render): add default type for Queries parameter #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2021
Merged

fix(render): add default type for Queries parameter #871

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8bbe3f
fix(types): add default type to render's parameter
solufa Feb 2, 2021
7f1008e
chore(types): add test for queries
solufa Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>
* Render into a container which is appended to document.body. It should be used with cleanup.
*/
export function render<
Q extends Queries,
Q extends Queries = typeof queries,
Container extends Element | DocumentFragment = HTMLElement
>(
ui: React.ReactElement,
Expand Down